-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(onboarding): Metrics page for .NET platforms #106552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
alexander-alderman-webb
wants to merge
4
commits into
webb/dotnet-metrics
Choose a base branch
from
webb/dotnet-metrics-page
base: webb/dotnet-metrics
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f3ad0c7
feat(onboarding): Metrics page for .NET platforms
alexander-alderman-webb c2f8de8
rename metrics function
alexander-alderman-webb dc6df68
Merge branch 'webb/dotnet-metrics' into webb/dotnet-metrics-page
alexander-alderman-webb c8a37fc
Merge branch 'webb/dotnet-metrics' into webb/dotnet-metrics-page
alexander-alderman-webb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| // Only import and test functions that don't have circular dependencies | ||
| const {dotnetMetrics} = jest.requireActual('sentry/gettingStartedDocs/dotnet/metrics'); | ||
|
|
||
| describe('metrics', () => { | ||
| const mockParams = { | ||
| dsn: { | ||
| public: 'https://[email protected]/123', | ||
| }, | ||
| sourcePackageRegistries: { | ||
| isLoading: false, | ||
| }, | ||
| }; | ||
|
|
||
| it('generates metrics onboarding config with default parameters', () => { | ||
| const result = dotnetMetrics(); | ||
|
|
||
| // Test install step | ||
| const installSteps = result.install(mockParams); | ||
| expect(installSteps).toHaveLength(1); | ||
| expect(installSteps[0].type).toBe('install'); | ||
| expect(installSteps[0].content).toHaveLength(2); | ||
|
|
||
| // Test verify step | ||
| const verifySteps = result.verify(mockParams); | ||
| expect(verifySteps).toHaveLength(1); | ||
| expect(verifySteps[0].type).toBe('verify'); | ||
| expect(verifySteps[0].content).toHaveLength(3); | ||
| const codeSnippet = verifySteps[0].content[1].code; | ||
|
|
||
| expect(codeSnippet).toContain('SentrySdk.Init'); | ||
| expect(codeSnippet).toContain(mockParams.dsn.public); | ||
| expect(codeSnippet).toContain('Metrics.EmitCounter'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,9 @@ import {getPackageVersion} from 'sentry/utils/gettingStartedDocs/getPackageVersi | |
|
|
||
| export const getInstallSnippetPackageManager = (params: DocsParams) => { | ||
| let version = '3.34.0'; | ||
| if (params.isLogsSelected) { | ||
| if (params.isMetricsSelected) { | ||
| version = '6.1.0'; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. todo: update to actual version when published |
||
| } else if (params.isLogsSelected) { | ||
| version = '6.0.0'; | ||
| } else if (params.isProfilingSelected) { | ||
| version = '4.3.0'; | ||
|
|
@@ -15,7 +17,9 @@ Install-Package Sentry -Version ${getPackageVersion(params, 'sentry.dotnet', ver | |
|
|
||
| export const getInstallSnippetCoreCli = (params: DocsParams) => { | ||
| let version = '3.34.0'; | ||
| if (params.isLogsSelected) { | ||
| if (params.isMetricsSelected) { | ||
| version = '6.1.0'; | ||
| } else if (params.isLogsSelected) { | ||
| version = '6.0.0'; | ||
| } else if (params.isProfilingSelected) { | ||
| version = '4.3.0'; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: see getsentry/sentry-docs#16054