Skip to content

feat(aci): Display apdex option for spans #103791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat(aci): Display apdex option for spans #103791

wants to merge 10 commits into from
+191 −29

Conversation

@scttcper
Copy link
Member

@scttcper scttcper commented Nov 20, 2025 •
edited
Loading

brings back apdex option for spans

stacked on #103697

image

@scttcper
fix(aci): Hide failure rate and hide string options for p50
dd5cb03 
- hides failure rate and failure count options from metric monitors
- hides string tags for aggregate functions like p50, p90
@scttcper
only disallow aggregates for logs
6e9ced7
@scttcper
Merge branch 'master' into scttcper/fix-aci-EAP-options
c4125b4
@scttcper
feat(aci): Display apdex option for spans
f85a038 
Adds back the apdex option and a test so it doesn't disappear.
@scttcper
move
00b02d3
@scttcper scttcper requested a review from a team as a code owner November 20, 2025 23:36
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 20, 2025
cursor[bot]
cursor bot reviewed Nov 20, 2025
View reviewed changes
Base automatically changed from scttcper/fix-aci-EAP-options to master November 20, 2025 23:56
malwilley
malwilley reviewed Nov 20, 2025
View reviewed changes
static/app/views/detectors/components/forms/metric/visualize.tsx Outdated
const LOCKED_SPAN_AGGREGATES = {
[AggregationKey.APDEX]: {
value: DEFAULT_VISUALIZATION_FIELD,
label: t('span.duration'),
Copy link
Member

@malwilley malwilley Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be cleaner if you just set span.duration to be the single allowable type for this parameter

Copy link
Member Author

@scttcper scttcper Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is what this is doing, i've removed the disabled

@scttcper
Merge branch 'master' into scttcper/add-apdex-option
77e979e 
# Conflicts:
#	static/app/views/detectors/components/forms/metric/visualize.tsx
@scttcper
remove casting to any
3747cec
@codecov
Copy link

codecov bot commented Nov 21, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
12658 1 12657 10
View the top 1 failed test(s) by shortest run time 
DetectorEdit Metric disables column select when spans + count()
Stack Traces | 0.371s run time 
Error: expect(element).toBeDisabled()

Received element is not disabled:
  <button aria-disabled="false" aria-expanded="false" aria-haspopup="listbox" class="en302zp1 css-g0v7il-StyledButton-getColors-getFocusState-getColors-getSizeStyles-getBoxShadow-DO_NOT_USE_getButtonStyles-StyledButton e1hnfhxi2" data-react-aria-pressable="true" id="_r_uc_" role="button" tabindex="0" type="button" />
    at Object.toBeDisabled (.../views/detectors/edit.spec.tsx:609:22)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malwilley malwilley malwilley left review comments

@cursor cursor[bot] cursor[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scttcper @malwilley