Skip to content

fix(aci): Hide failure rate and hide string options for p50 #103697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2025
Merged

fix(aci): Hide failure rate and hide string options for p50 #103697

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd5cb03
fix(aci): Hide failure rate and hide string options for p50
scttcper Nov 19, 2025
6e9ced7
only disallow aggregates for logs
scttcper Nov 20, 2025
c4125b4
Merge branch 'master' into scttcper/fix-aci-EAP-options
scttcper Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 44 additions & 11 deletions static/app/views/detectors/components/forms/metric/visualize.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ import {parseFunction} from 'sentry/utils/discover/fields';
import {
AggregationKey,
ALLOWED_EXPLORE_VISUALIZE_AGGREGATES,
FieldValueType,
getFieldDefinition,
prettifyTagKey,
} from 'sentry/utils/fields';
import {unreachable} from 'sentry/utils/unreachable';
Expand Down Expand Up @@ -91,13 +93,27 @@ function renderTag(kind: FieldValueKind): React.ReactNode {
return <Tag type={tagType}>{text}</Tag>;
}

const LOGS_NOT_ALLOWED_AGGREGATES = [
AggregationKey.FAILURE_RATE,
AggregationKey.FAILURE_COUNT,
];

function getEAPAllowedAggregates(dataset: DetectorDataset): Array<[string, string]> {
return ALLOWED_EXPLORE_VISUALIZE_AGGREGATES.filter(aggregate => {
if (dataset === DetectorDataset.LOGS) {
return !LOGS_NOT_ALLOWED_AGGREGATES.includes(aggregate);
}
return true;
}).map(aggregate => [aggregate, aggregate]);
}

function getAggregateOptions(
dataset: DetectorDataset,
tableFieldOptions: Record<string, SelectValue<FieldValue>>
): Array<[string, string]> {
// For spans dataset, use the predefined aggregates
if (dataset === DetectorDataset.SPANS || dataset === DetectorDataset.LOGS) {
return ALLOWED_EXPLORE_VISUALIZE_AGGREGATES.map(aggregate => [aggregate, aggregate]);
return getEAPAllowedAggregates(dataset);
}

// For other datasets, extract function-type options from tableFieldOptions
Expand All @@ -107,7 +123,7 @@ function getAggregateOptions(

// If no function options available, fall back to the predefined aggregates
if (functionOptions.length === 0) {
return ALLOWED_EXPLORE_VISUALIZE_AGGREGATES.map(aggregate => [aggregate, aggregate]);
return getEAPAllowedAggregates(dataset);
}

return functionOptions.sort((a, b) => a[1].localeCompare(b[1]));
Expand Down Expand Up @@ -218,15 +234,32 @@ export function Visualize() {
const fieldOptions = useMemo(() => {
// For Spans dataset, use span-specific options from the provider
if (dataset === DetectorDataset.SPANS || dataset === DetectorDataset.LOGS) {
// Use field definition to determine what options should be displayed
const fieldDefinition = getFieldDefinition(
aggregate,
dataset === DetectorDataset.SPANS ? 'span' : 'log'
);
let isTypeAllowed = (_valueType: FieldValueType) => true;
if (fieldDefinition?.parameters?.[0]?.kind === 'column') {
const columnTypes = fieldDefinition?.parameters[0]?.columnTypes;
isTypeAllowed = (valueType: FieldValueType) =>
typeof columnTypes === 'function'
? columnTypes({key: '', valueType})
: columnTypes.includes(valueType);
}
const spanColumnOptions: Array<[string, string]> = [
...Object.values(stringSpanTags).map((tag): [string, string] => [
tag.key,
prettifyTagKey(tag.name),
]),
...Object.values(numericSpanTags).map((tag): [string, string] => [
tag.key,
prettifyTagKey(tag.name),
]),
...(isTypeAllowed(FieldValueType.STRING)
? Object.values(stringSpanTags).map((tag): [string, string] => [
tag.key,
prettifyTagKey(tag.name),
])
: []),
...(isTypeAllowed(FieldValueType.NUMBER)
? Object.values(numericSpanTags).map((tag): [string, string] => [
tag.key,
prettifyTagKey(tag.name),
])
: []),
];
return spanColumnOptions.sort((a, b) => a[1].localeCompare(b[1]));
}
Expand All @@ -239,7 +272,7 @@ export function Visualize() {
)
.map((option): [string, string] => [option.value.meta.name, option.value.meta.name])
.sort((a, b) => a[1].localeCompare(b[1]));
}, [dataset, stringSpanTags, numericSpanTags, aggregateOptions]);
}, [dataset, stringSpanTags, numericSpanTags, aggregateOptions, aggregate]);

const fieldOptionsDropdown = useMemo(() => {
return fieldOptions.map(([value, label]) => ({
Expand Down
Loading