perf(query-builder): Do not render filter value suggestions when they're not open

[gggritso]

This is an optimization for the SearchQueryBuilder component. Here's the issue I'm seeing:

• SearchQueryBuilder is rendered (or re-rendered, whichever) with unstable props (because the props are hard to stabilize, which happens sometimes, or why rendering for the first time)
• The render is fairly slow, it can take anywhere in the 50-100ms time range
• One of the slower parts is rendering SearchQueryBuilderComboBox. This takes a long time to render because it uses React Stately's useComboBoxState. This hook accepts the children props, which is the collection renderer. It renders all the items at this point, even if the combo box is not open!

So, the entire collection is rendered even if it's not open. This PR does a trick in which if we know the combo box is not open, it provides a null children, so the extra work doesn't have to be done. This saves ~30ms per free text token in the builder, which can be a lot, if there are many tokens, since there's free text around each one.

As far as I can tell, this doesn't cause any adverse effects on the UI.

Before:

After:

[linear]

DAIN-1097 Prevent rendering closed combo box contents

[malwilley]

Good find! I wish React Stately would lazily generate the items itself, but it looks like this is a good solution. I've tested and it doesn't look like it works any differently, so looks good to merge 👍

[malwilley]

Oops, meant to approve!