Skip to content

Conversation

@Mihir-Mavalankar
Copy link
Contributor

@Mihir-Mavalankar Mihir-Mavalankar commented Nov 19, 2025

PR details

  • Fix to make sure change to "Where should Seer Stop" persists. Added getData: () => ({}) to the automatedRunStoppingPointField to prevent the Form from including this field in its auto-save payload to the Project API. This fixes the bug where the field's custom onChange handler correctly saved to the Seer Preferences API, but the Form also tried to save it to the Project API (which doesn't support this field), creating a false success message while the setting never persisted.
  • More context: https://sentry.slack.com/archives/C09QCAEA0DR/p1763404095142179
  • The fix is to not store it in Project API but just store it in Seer Preferences API.
  • Not super sure on this one. Apparently Claude says this bug was there even before the triage-signals changes.

@Mihir-Mavalankar Mihir-Mavalankar self-assigned this Nov 19, 2025
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 19, 2025
@Mihir-Mavalankar
Copy link
Contributor Author

I ran this query on redash and looks like most projects are either RCA(current default) or solution(previous default) - https://redash.getsentry.net/queries/9941/source
If this was always a bug this makes sense but not sure how the orgs that don't have RCA and solution changed it.

Copy link
Member

@roaga roaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not really sure how these settings components work, maybe somebody else can review

@jennmueng
Copy link
Member

yeah, this makes sense, roughly, but like rohan said I have no context either

@jennmueng jennmueng requested a review from a team November 20, 2025 15:54
Copy link
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be okay for now

@Mihir-Mavalankar Mihir-Mavalankar marked this pull request as ready for review November 20, 2025 21:24
@Mihir-Mavalankar Mihir-Mavalankar merged commit 1fa42e1 into master Nov 20, 2025
53 checks passed
@Mihir-Mavalankar Mihir-Mavalankar deleted the fix-settings-ui-bug branch November 20, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants