feat(aci): redirect alert rules to detectors

[ameliahsu]

redirects metric alert rules and uptime monitors to the new monitors views.

note that links to cron monitors do not get redirected at the moment since that would require a lookup from the monitorSlug to the detectorId

[codecov]

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

[saponifi3d]

i just generally have nits, but not super familiar with the routing layer here -- would recommend getting a second set of eyes for that stuff.

[saponifi3d]

curious about the !user.isStaff piece here, is that so we can continue with everything as is today w/o redirecting? might be nice to just have staff use the same experience; and this could be a nice forcing function for everyone to dog food this before we flip the LA switch.

[ameliahsu]

Adding the isStaff check makes it easier for us to compare the old vs. new experience while developing, so I'd like to keep this check for now

[saponifi3d]

nit: recommend against having nested ternaries, makes readability even with these indentations a bit tricky.

Maybe something like:

const getDetectionType = (alertType: string): string => {
  switch(alertType) {
    case 'crons':
      return 'monitor_check_in_failure';
    case 'uptime':
      return 'uptime_domain_failure';
    default:
      return null;
  }
}

// in use
const detectorType = getDetectionType(alertType);

this makes it a little easier to quickly read, but also makes it a lot easier to add a 3rd type if we need to or anything.

[scttcper]

import should still be lazy

[scttcper]

can we make this a hook (or small HoCish wrapper for class components) and wrap the areas we want to redirect instead. Adding these to the route tree doesn't totally make sense if they aren't views

[malwilley]

This can't be a hook because it needs to render the loading state while the requests are in flight, but it could be an HoC. That would feel cleaner and wouldn't require changing the route tree

[scttcper]

i think that's where i'm at yeah this shouldn't need to be in the route tree

[malwilley]

Unfortunately this isn't completely lazy, you need to make a new file with a default export that is export default withDetectorDetailsRedirect(MetricDetails)