feat(explore): Update confidence footer again #103680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update follows a few philosophies: 1. use the number matched, number scanned, number total to inform the user 2. give as much information to the user as possible about what was done to compute the results 3. never display the same number more than once as it is repetitive/redundant
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| downsampledLogsCount, | ||
| allLogsCount, | ||
| tooltip: downsampledTooltip, | ||
| totalLogsCount, |
Contributor
There was a problem hiding this comment.
Bug: Full scan with user query misrepresents results as estimated
When a user query is provided and a full scan is performed, the footer incorrectly labels results with "Estimated from X matches", implying uncertainty from sampling. Since a full scan scanned all available data without sampling, the results are actual counts, not estimates. The word "Estimated" is misleading in this context. Additionally, this code path is currently untested and uses maybeWarning and maybeTooltip which are always null when dataScanned === 'full', making the output inconsistent with the intended user-facing meaning.
nsdeschenes
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update follows a few philosophies: