feat(events): Add rpc request even on error #103678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wmak
commented
Nov 19, 2025
wmak
commented
- Currently we only return the rpc request when there's no error, but it would be (more) helpful to get it when there is an error
- Currently we only return the rpc request when there's no error, but it would be (more) helpful to get it when there is an error
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103678 +/- ##
===========================================
+ Coverage 80.57% 80.58% +0.01%
===========================================
Files 9255 9263 +8
Lines 395176 395573 +397
Branches 25198 25198
===========================================
+ Hits 318407 318784 +377
- Misses 76340 76360 +20
Partials 429 429 |
k-fish
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.