feat(preprod): Add app-icon download endpoint

[rbro112]

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

[rbro112]

• Wireup app icon frontend #102118
• feat(preprod): Add app-icon download endpoint #102117 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[rbro112]

I think we'll want to preserve this path

[sentry-io]

Bug: urls.py imports ProjectPreprodArtifactImageEndpoint from a non-existent module project_preprod_artifact_icon.
_{Severity: CRITICAL | Confidence: 1.00}

🔍 Detailed Analysis

The urls.py file attempts to import ProjectPreprodArtifactImageEndpoint from sentry.preprod.api.endpoints.project_preprod_artifact_icon on line 5. However, the module project_preprod_artifact_icon.py does not exist. The intended class ProjectPreprodArtifactImageEndpoint is defined in project_preprod_artifact_image.py. This mismatch will cause a ModuleNotFoundError when the application attempts to load URL patterns, preventing the application from starting.

💡 Suggested Fix

Correct the import path in src/sentry/preprod/api/endpoints/urls.py from sentry.preprod.api.endpoints.project_preprod_artifact_icon to sentry.preprod.api.endpoints.project_preprod_artifact_image.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/sentry/preprod/api/endpoints/urls.py#L5-L6

Potential issue: The `urls.py` file attempts to import
`ProjectPreprodArtifactImageEndpoint` from
`sentry.preprod.api.endpoints.project_preprod_artifact_icon` on line 5. However, the
module `project_preprod_artifact_icon.py` does not exist. The intended class
`ProjectPreprodArtifactImageEndpoint` is defined in `project_preprod_artifact_image.py`.
This mismatch will cause a `ModuleNotFoundError` when the application attempts to load
URL patterns, preventing the application from starting.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

[sentry-io]

Bug: HttpResponse is incorrectly used with dictionary objects at lines 117, 129, 140.
_{Severity: CRITICAL | Confidence: 1.00}

🔍 Detailed Analysis

The code at lines 117, 129, and 140 attempts to return HttpResponse with Python dictionary objects, such as HttpResponse({"error": "Not found"}, status=404). The HttpResponse constructor does not accept dictionaries directly; it expects content as strings, bytes, or iterators. This will result in a TypeError during response serialization, causing a generic 500 error to be returned to the client instead of the intended structured error response.

💡 Suggested Fix

Replace HttpResponse with JsonResponse when returning dictionary objects. For example, change return HttpResponse({"error": "Not found"}, status=404) to return JsonResponse({"error": "Not found"}, status=404).

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/sentry/preprod/api/endpoints/project_preprod_artifact_image.py#L117

Potential issue: The code at lines 117, 129, and 140 attempts to return `HttpResponse`
with Python dictionary objects, such as `HttpResponse({"error": "Not found"},
status=404)`. The `HttpResponse` constructor does not accept dictionaries directly; it
expects content as strings, bytes, or iterators. This will result in a `TypeError`
during response serialization, causing a generic 500 error to be returned to the client
instead of the intended structured error response.

_{Did we get this right? 👍 / 👎 to inform future reviews.}