fix(aci): correctly load condition sub-filters on alert edit #101972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
approved these changes
Oct 22, 2025
| const {subfilter, subfilter_id, onUpdate} = useSubfilterContext(); | ||
|
|
||
| if (!subfilter.type) { | ||
| if ('attribute' in subfilter || 'key' in subfilter) { |
There was a problem hiding this comment.
It might be helpful to define the types as type Subfilter = AttributeSubfilter | KeySubfilter
And then you can use a user defined type predicate to narrow the type:
function isAttributeSubfilter(subfilter: Subfilter): subfilter is AttributeSubfilter {
return ''attribute' in subfilter
}This improves the readability and gives better type safety.
I'm noticing that subfilter is typed as Record<string, any> which we can definitely go back and improve at some point (doesn't have to be in this PR)
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than adding a temporary
typefield on condition subfilters, this change adds logic to check for either anattributeorkeyfield on the subfilter to determine if it's an attribute or tag filterusing the
typeto determine the filter (attribute/tag) would not work when loading an existing alert into the builder when editing an alert, since it was just a temporary field being added in the ui during the alert creation flow