Skip to content

chore(eco): temporarily unstuck sentry app install deletion #101895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

chore(eco): temporarily unstuck sentry app install deletion #101895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/sentry/deletions/defaults/sentry_app_installation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from sentry.deletions.base import BaseRelation, ModelDeletionTask, ModelRelation
from sentry.deletions.defaults.apigrant import ModelApiGrantDeletionTask
from sentry.sentry_apps.models.sentry_app_installation import SentryAppInstallation
from sentry.types.region import RegionMappingNotFound
from sentry.workflow_engine.service.action import action_service


Expand All @@ -29,10 +30,13 @@ def mark_deletion_in_progress(self, instance_list: Sequence[SentryAppInstallatio
pass

def delete_instance(self, instance: SentryAppInstallation) -> None:
action_service.update_action_status_for_sentry_app_via_uuid(
organization_id=instance.organization_id,
status=ObjectStatus.DISABLED,
sentry_app_install_uuid=instance.uuid,
)
try:
action_service.update_action_status_for_sentry_app_via_uuid(
organization_id=instance.organization_id,
status=ObjectStatus.DISABLED,
sentry_app_install_uuid=instance.uuid,
)
except RegionMappingNotFound:
pass

return super().delete_instance(instance)
Loading