feat(open periods): Add activities to open period serializer #100627
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #100627 +/- ##
===========================================
+ Coverage 81.14% 81.19% +0.05%
===========================================
Files 8599 8616 +17
Lines 380806 382141 +1335
Branches 23911 23911
===========================================
+ Hits 308993 310271 +1278
- Misses 71451 71508 +57
Partials 362 362 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tests/sentry/workflow_engine/endpoints/test_organization_open_periods.py
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
saponifi3d
left a comment
saponifi3d
left a comment
There was a problem hiding this comment.
lgtm! (also thanks for the initial review malachi!)
src/sentry/workflow_engine/endpoints/serializers/group_open_period_serializer.py
Show resolved
Hide resolved
mifu67
left a comment
mifu67
left a comment
There was a problem hiding this comment.
Looks good, thank you for doing this!
src/sentry/workflow_engine/endpoints/serializers/group_open_period_serializer.py
Outdated
Show resolved
Hide resolved
| ) | ||
| activities = GroupOpenPeriodActivity.objects.filter( | ||
| group_open_period__in=item_list | ||
| ).order_by("id") |
There was a problem hiding this comment.
Could also order by date_added, but this works too :)
| return GroupOpenPeriodActivityResponse( | ||
| id=str(obj.id), | ||
| type=OpenPeriodActivityType(obj.type).to_str(), | ||
| value=PriorityLevel(obj.value).to_str() if obj.value else None, |
There was a problem hiding this comment.
Bug: Serializer Fails to Handle Zero Priority Levels
The GroupOpenPeriodActivitySerializer incorrectly treats obj.value as falsy when its value is 0. Since 0 is a valid PriorityLevel, this causes the serializer to return None instead of the string representation for priority level 0.
There was a problem hiding this comment.
0 is not a valid PriorityLevel https://github.com/getsentry/sentry/blob/master/src/sentry/types/group.py#L63-L66
| ): | ||
| gopas[activity.group_open_period].append(serialized_activity) | ||
| for item in item_list: | ||
| result[item]["activities"] = gopas[item][:100] |
There was a problem hiding this comment.
Bug: Overfetching and Serialization Issues
The get_attrs method fetches and serializes all GroupOpenPeriodActivity records for each GroupOpenPeriod, even though only the first 100 are used. This can cause significant memory and processing overhead. Additionally, zipping the activities queryset with its serialized output risks an ordering mismatch, potentially leading to incorrect data associations.
Add
GroupOpenPeriodActivityresults to the group open period serializer response.