Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tagstore to query issue platform issues #42589

Closed
wedamija opened this issue Dec 22, 2022 · 1 comment · Fixed by #42908
Closed

Allow tagstore to query issue platform issues #42589

wedamija opened this issue Dec 22, 2022 · 1 comment · Fixed by #42908
Assignees

Comments

@wedamija
Copy link
Member

wedamija commented Dec 22, 2022

Currently tagstore works with errors and performance issues. We want to allow it to query any issue platform related issues as well.

This might be the only place we need to touch:

def apply_group_filters_conditions(self, group: Group, conditions, filters):
dataset = Dataset.Events
if group:
if group.issue_category == GroupCategory.PERFORMANCE:
dataset = Dataset.Transactions
apply_performance_conditions(conditions, group)
else:
filters["group_id"] = [group.id]
return dataset, conditions, filters

Probably just need to change the dataset to be the issue platform one if not error/performance.

Should also make sure that we write tests that query the issue platform. There should be examples related to performance issues.

@ceorourke
Copy link
Member

Blocked by getsentry/snuba#3571 - someone else can pick this up if they want.

ceorourke added a commit that referenced this issue Jan 9, 2023
…42908)

Fall back to a default dataset for non error / performance issues to
allow tagstore to work for the issue platform.

Closes #42589
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants