Skip to content

Commit

Permalink
Remove Sentry warnings and GCP logs for throttled queries (#73549)
Browse files Browse the repository at this point in the history
Snuba throttles queries in the magnitude of 10k-20k. A [previous
PR](#73442) emits a warning to
Sentry and logs to GCP for every throttled query, and thus has the
potential to overwhelm Sentry/GCP. This PR removes the warnings and logs
in case we have an incident.

Co-authored-by: Rachel Chen <[email protected]>
  • Loading branch information
xurui-c and Rachel Chen authored Jul 1, 2024
1 parent ae2388a commit ffd0389
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/sentry/utils/snuba.py
Original file line number Diff line number Diff line change
Expand Up @@ -1069,8 +1069,6 @@ def _bulk_snuba_query(
"throttled_by" in quota_allowance_summary
and quota_allowance_summary["throttled_by"]
):
logger.warning("Query is throttled", extra={"response.data": response.data})
sentry_sdk.capture_message("Query is throttled", level="warning")
metrics.incr("snuba.client.query.throttle", tags={"referrer": query_referrer})

if response.status != 200:
Expand Down

0 comments on commit ffd0389

Please sign in to comment.