fix(ddm): Remove connected nulls (#65221)

getsentry · Feb 15, 2024 · 6d75ec1 · 6d75ec1
1 parent 639faec
commit 6d75ec1
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/static/app/views/ddm/chart.tsx b/static/app/views/ddm/chart.tsx
@@ -52,7 +52,7 @@ function isNonZeroValue(value: number | null) {
   return value !== null && value !== 0;
 }
 
-function addAreaChartSeriesPadding(data: Series['data']) {
+function addSeriesPadding(data: Series['data']) {
   const hasNonZeroSibling = (index: number) => {
     return (
       isNonZeroValue(data[index - 1]?.value) || isNonZeroValue(data[index + 1]?.value)
@@ -124,10 +124,9 @@ export const MetricChart = forwardRef<ReactEchartsRef, ChartProps>(
           .filter(s => !s.hidden)
           .map(s => ({
             ...s,
-            ...(displayType === MetricDisplayType.AREA
-              ? addAreaChartSeriesPadding(s.data)
+            ...(displayType !== MetricDisplayType.BAR
+              ? addSeriesPadding(s.data)
               : {data: s.data}),
-            connectNulls: displayType === MetricDisplayType.LINE,
           }))
           // Split series in two parts, one for the main chart and one for the fog of war
           // The order is important as the tooltip will show the first series first (for overlaps)