Skip to content

Commit

Permalink
fix(starfish): add quotes around transaction name (#53516)
Browse files Browse the repository at this point in the history
Add quotes around transaction name to prevent errors when the
transaction name has a space in it.
  • Loading branch information
DominikB2014 authored and chloeho7 committed Jul 25, 2023
1 parent fd4aea6 commit 641ccc3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion static/app/views/starfish/queries/useSpanMetrics.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ function getEventView(
name: '',
query: `${SPAN_GROUP}:${group}${
queryFilters?.transactionName
? ` transaction:${queryFilters?.transactionName}`
? ` transaction:"${queryFilters?.transactionName}"`
: ''
}${
queryFilters?.['transaction.method']
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/starfish/queries/useSpanMetricsSeries.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function getEventView(
name: '',
query: `${SPAN_GROUP}:${group}${
queryFilters?.transactionName
? ` transaction:${queryFilters?.transactionName}`
? ` transaction:"${queryFilters?.transactionName}"`
: ''
}${
queryFilters?.['transaction.method']
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/starfish/queries/useSpanSamples.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const useSpanSamples = (options: Options) => {

const query = new MutableSearch([
`${SPAN_GROUP}:${groupId}`,
`transaction:${transactionName}`,
`transaction:"${transactionName}"`,
`transaction.method:${transactionMethod}`,
]);

Expand Down

0 comments on commit 641ccc3

Please sign in to comment.