Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Apr 18, 2025

Add a step asking user if they want to add the feedback widget.

Part of getsentry/sentry-react-native#4302

Screenshot 2025-04-22 at 1 14 37 PM

@github-actions
Copy link

github-actions bot commented Apr 18, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against fd361d6

@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 35.36585% with 53 lines in your changes missing coverage. Please review.

Project coverage is 27.24%. Comparing base (7e38ffe) to head (fd361d6).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/react-native/react-native-wizard.ts 5.00% 38 Missing ⚠️
src/react-native/javascript.ts 64.28% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
+ Coverage   27.21%   27.24%   +0.03%     
==========================================
  Files         129      129              
  Lines       14218    14284      +66     
  Branches      843      849       +6     
==========================================
+ Hits         3869     3892      +23     
- Misses      10331    10374      +43     
  Partials       18       18              
Flag Coverage Δ
unit-tests 27.24% <35.36%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

return ` integrations: [${
enableSessionReplay ? 'Sentry.mobileReplayIntegration()' : ''
}${enableSessionReplay && enableFeedbackWidget ? ', ' : ''}${
enableFeedbackWidget ? 'Sentry.feedbackIntegration()' : ''
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding the integration for now. We may add more options with with feature drop 2 (e.g. enable capture screenshot)

@antonis antonis marked this pull request as ready for review April 22, 2025 10:17
@antonis antonis requested a review from krystofwoldrich April 22, 2025 10:17
# Conflicts:
#	CHANGELOG.md
#	src/react-native/javascript.ts
Copy link
Contributor

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Ty!

@antonis antonis merged commit 7f5e924 into master Apr 24, 2025
44 checks passed
@antonis antonis deleted the antonis/rn-feedback-widget branch April 24, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants