Skip to content

Fix check if symfony/http-client is installed#858

Merged
cleptric merged 1 commit into
masterfrom
fix-http-client-installed-check
Jul 2, 2024
Merged

Fix check if symfony/http-client is installed#858
cleptric merged 1 commit into
masterfrom
fix-http-client-installed-check

Conversation

@cleptric
Copy link
Copy Markdown
Member

@cleptric cleptric commented Jul 1, 2024

We need to check if Symfony\Component\HttpClient\HttpClient exists, as Symfony\Contracts\HttpClient\HttpClientInterface could be pulled in via symfony/contracts.

Fixes #855.

@cleptric cleptric self-assigned this Jul 1, 2024
@cleptric cleptric added the Bug label Jul 1, 2024
@cleptric cleptric requested a review from stayallive July 1, 2024 20:51
@cleptric cleptric mentioned this pull request Jul 1, 2024
Closed
@cleptric cleptric merged commit bdcec61 into master Jul 2, 2024
@cleptric cleptric deleted the fix-http-client-installed-check branch July 2, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stayallive stayallive Awaiting requested review from stayallive

1 more reviewer

@Jean85 Jean85 Jean85 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cleptric cleptric

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TraceableResponseForV4::getInfo must be compatible with ResponseInterface::getInfo

2 participants

@cleptric @Jean85