Skip to content

Conversation

@solnic
Copy link
Collaborator

@solnic solnic commented Sep 15, 2025

Closes #2691

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.31%. Comparing base (5a2a6b9) to head (ca0ba41).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2700      +/-   ##
==========================================
+ Coverage   97.29%   97.31%   +0.02%     
==========================================
  Files         144      144              
  Lines        5647     5652       +5     
==========================================
+ Hits         5494     5500       +6     
+ Misses        153      152       -1     
Components Coverage Δ
sentry-ruby 97.77% <100.00%> (+<0.01%) ⬆️
sentry-rails 95.61% <ø> (ø)
sentry-sidekiq 96.57% <ø> (ø)
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (+0.68%) ⬆️
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/log_event.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@solnic solnic marked this pull request as ready for review September 16, 2025 06:43
@solnic solnic requested a review from dingsdax September 16, 2025 06:50
Copy link
Contributor

@dingsdax dingsdax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@solnic solnic merged commit 1da1c2d into master Sep 16, 2025
143 checks passed
@solnic solnic deleted the 2691-make-sure-the-ruby-sdk-only-set-sentrymessagetemplate-on-logs-if-sentrymessageparameter-values-are-also-defined branch September 16, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sure the Ruby SDK only set sentry.message.template on logs if sentry.message.parameter values are also defined

3 participants