Goodbye faraday 👋

[st0012]

1. Removed faraday_builder and http_adapter transport configs.
2. Rewrote HTTPTransport with pure Net::HTTP implementation. (faraday-net_http provided pretty good guidance)
3. Removed faraday from dependencies.

Todo

• Test against different versions of Net::HTTP to see if the implementation can work from Ruby 2.4~3.1
• Update migration guide and documentation.

Closes #1663

[st0012]

@sl0thentr0py It seems to work 🎉

[ojab]

btw, are other transports welcome? We're using httpx for API clients, because it has nice API and HTTP/2 + persistent connections support. It wouldn't hurt to use it for interactions with sentry, curling DSN says that it's HTTP/2. The same question about adding breadcrumbs for it.

Sorry for offtopic, dunno where to ask.

[st0012]

@ojab You can always use config.transport.transport_class to assign your custom transports. But I don't plan to introduce other built-in transports, especially not the ones that relies on 3rd-party libraries (so we don't need to go through a similar issue as #1663 a few years later).
With that being said, I'd be happy to help if you want to introduce something like sentry-httpx to support both the transport and breadcrumb support 😄

[ojab]

You mean as sentry-rails works currently, still in the same repo, just as a different gem?

[st0012]

Oh no I mean you can write your own sentry-httpx gem (or whatever you want to call it). I can give you pointers on how to write breadcrumb loggers and transports if you need any.

[trevorturk]

Excellent work on the changelog entry, thank you!