Skip to content

Conversation

@st0012
Copy link
Contributor

@st0012 st0012 commented Nov 21, 2021

Transport's configuration allows users to configure ssl options with a Ruby hash:

configuration.transport.ssl = { key: value }

or with specific options:

configuration.transport.ssl_verification = false
configuration.transport.ssl_ca_file = file

But there's a bug that will always override the ssl (Hash) option's verify and ca_file values with specific options' values (usually nil in this case).

This bug seems to exist for years (from sentry-raven era), which makes me wonder if anyone really uses the ssl option 🤔

The PR fixes the issue and adds tests for all transport configuration options.

@st0012 st0012 added this to the 4.8.1 milestone Nov 21, 2021
@st0012 st0012 self-assigned this Nov 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.49%. Comparing base (b61bc0d) to head (941e514).
⚠️ Report is 680 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1626      +/-   ##
==========================================
- Coverage   98.50%   98.49%   -0.01%     
==========================================
  Files         133      133              
  Lines        7336     7382      +46     
==========================================
+ Hits         7226     7271      +45     
- Misses        110      111       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 force-pushed the improve-http-transport-tests branch from ed7b3f8 to 941e514 Compare November 21, 2021 12:07
@st0012 st0012 requested a review from sl0thentr0py November 21, 2021 12:10
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which makes me wonder if anyone really uses the ssl option

^^

lgtm!

@st0012 st0012 merged commit 805b692 into master Nov 22, 2021
@st0012 st0012 deleted the improve-http-transport-tests branch November 22, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants