Skip to content

dotnet(nuget): add missing Sentry.Maui.CommunityToolkit.Mvvm - #242

Merged
Lms24 merged 1 commit into
getsentry:masterfrom
jamescrosswell:dotnet/add-maui-communitytoolkit-mvvm
Aug 18, 2026
Merged

dotnet(nuget): add missing Sentry.Maui.CommunityToolkit.Mvvm#242
Lms24 merged 1 commit into
getsentry:masterfrom
jamescrosswell:dotnet/add-maui-communitytoolkit-mvvm

Conversation

@jamescrosswell

@jamescrosswell jamescrosswell commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Context

Summary

Sentry.Maui.CommunityToolkit.Mvvm has shipped on NuGet since 5.8.0 but was never added here. getsentry/sentry-dotnet#5456 added it to sentry-dotnet's .craft.yml registry target, and the 6.9.0 publish then aborted (run 32010411662):

[error] "name" is required for new package "nuget:Sentry.Maui.CommunityToolkit.Mvvm".
        Add `name` to the registry target config in your .craft.yml.

Craft treats a package as new only when its latest.json is missing, so seeding the directory here makes the bare .craft.yml key work exactly as it does for the other 18 sentry-dotnet packages.

The failure isn't scoped to this one package — updateVersionInRegistry throws before craft commits anything, so the whole registry target rolls back. Every sentry-dotnet package is currently still pinned at 6.8.0 here, two releases into 6.9.0 being live on NuGet.

Notes for review

  • Seeded at 6.8.0, not 6.9.0, deliberately. Craft aborts with Version file for "6.9.0" already exists. Aborting. if the version being published is already present — which would roll the target back again and leave all 19 packages stuck at 6.8.0. Seeding the previous version (which the package did ship) lets the retry create 6.9.0 and re-point the symlinks. dotnet(nuget): add missing Sentry.Hangfire #223 did the same, seeding 6.0.0-rc.2-prerelease.
  • canonical has to match the .craft.yml key exactly or craft errors on the consistency check in getUpdatedManifest.
  • created_at is the value craft wrote for the sibling packages in the 6.8.0 release, since it's the same release event.
  • Symlinks generated with bin/sync-links, not by hand. I also re-ran the full make sync-all-links (via xargs, as the bare find blows the argument limit on macOS) and confirmed it reproduces the committed tree exactly, so the CI sync check should be clean.
  • No sdks/sentry.dotnet.maui.communitytoolkit.mvvm symlink. Every other dotnet package has one, but this package doesn't emit its own sdk_info.name — its events go out as sentry.dotnet.maui — so the entry would name something nothing reports. Happy to add it if uniformity is preferred.

Relationship to getsentry/sentry-dotnet#5496

#5496 approaches the same failure from the other side: it gives sentry-dotnet's .craft.yml the name/packageUrl/mainDocsUrl that craft needs to create manifests itself — for every package, not just this one, so the next new package doesn't repeat this.

The two are complementary rather than exclusive. This PR unblocks the 6.9.0 retry now; #5496 stops it happening again. If both land, this package's .craft.yml entry is simply belt-and-braces — craft applies the config over the manifest on every release either way.

The package has shipped on NuGet since 5.8.0 but was never added here. It was
added to sentry-dotnet's .craft.yml registry target in
getsentry/sentry-dotnet#5456, and the 6.9.0 publish then aborted:

    "name" is required for new package "nuget:Sentry.Maui.CommunityToolkit.Mvvm".
    Add `name` to the registry target config in your .craft.yml.

Craft treats a package as new when its latest.json is missing, so seeding the
directory here lets the bare .craft.yml key work as it does for every other
sentry-dotnet package.

Seeded at 6.8.0 rather than 6.9.0 deliberately: craft aborts the whole registry
target with "Version file for 6.9.0 already exists" if the version being
published is already present, which would leave all 19 sentry-dotnet packages
stuck at 6.8.0 exactly as they are now. Same approach as getsentry#223.

created_at matches the value craft wrote for the other packages in the 6.8.0
release. Symlinks generated with bin/sync-links.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@Lms24
Lms24 merged commit 4aaecd1 into getsentry:master Aug 18, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants