Experimental: Android UI profiling #5518
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| import type { Spec } from '../src/js/NativeRNSentry'; | ||
| import type { ReactNativeClientOptions } from '../src/js/options'; | ||
| import { NATIVE } from '../src/js/wrapper'; | ||
|
|
||
| jest.mock('react-native', () => { | ||
| let initPayload: ReactNativeClientOptions | null = null; | ||
|
|
||
| const RNSentry: Spec = { | ||
| addBreadcrumb: jest.fn(), | ||
| captureEnvelope: jest.fn(), | ||
| clearBreadcrumbs: jest.fn(), | ||
| crashedLastRun: jest.fn(), | ||
| crash: jest.fn(), | ||
| fetchNativeDeviceContexts: jest.fn(() => | ||
| Promise.resolve({ | ||
| someContext: { | ||
| someValue: 0, | ||
| }, | ||
| }), | ||
| ), | ||
| fetchNativeRelease: jest.fn(() => | ||
| Promise.resolve({ | ||
| build: '1.0.0.1', | ||
| id: 'test-mock', | ||
| version: '1.0.0', | ||
| }), | ||
| ), | ||
| setContext: jest.fn(), | ||
| setExtra: jest.fn(), | ||
| setTag: jest.fn(), | ||
| setUser: jest.fn(() => { | ||
| return; | ||
| }), | ||
| initNativeSdk: jest.fn(options => { | ||
| initPayload = options; | ||
| return Promise.resolve(true); | ||
| }), | ||
| closeNativeSdk: jest.fn(() => Promise.resolve()), | ||
| // @ts-expect-error for testing. | ||
| _getLastPayload: () => ({ initPayload }), | ||
| startProfiling: jest.fn(), | ||
| stopProfiling: jest.fn(), | ||
| }; | ||
|
|
||
| return { | ||
| NativeModules: { | ||
| RNSentry, | ||
| }, | ||
| Platform: { | ||
| OS: 'android', | ||
| }, | ||
| }; | ||
| }); | ||
|
|
||
| const RNSentry = require('react-native').NativeModules.RNSentry as Spec; | ||
|
|
||
| describe('Android UI Profiling Options', () => { | ||
| beforeEach(() => { | ||
| NATIVE.platform = 'android'; | ||
| NATIVE.enableNative = true; | ||
| jest.clearAllMocks(); | ||
| }); | ||
|
|
||
| it('passes androidProfilingOptions to native SDK', async () => { | ||
| await NATIVE.initNativeSdk({ | ||
| dsn: 'https://example@sentry.io/123', | ||
| enableNative: true, | ||
| autoInitializeNativeSdk: true, | ||
| devServerUrl: undefined, | ||
| defaultSidecarUrl: undefined, | ||
| mobileReplayOptions: undefined, | ||
| androidProfilingOptions: { | ||
| profileSessionSampleRate: 0.5, | ||
| lifecycle: 'trace', | ||
| startOnAppStart: true, | ||
| }, | ||
| }); | ||
|
|
||
| expect(RNSentry.initNativeSdk).toHaveBeenCalledWith( | ||
| expect.objectContaining({ | ||
| _experiments: expect.objectContaining({ | ||
| androidProfilingOptions: { | ||
| profileSessionSampleRate: 0.5, | ||
| lifecycle: 'trace', | ||
| startOnAppStart: true, | ||
| }, | ||
| }), | ||
| }), | ||
| ); | ||
| }); | ||
|
|
||
| it('passes androidProfilingOptions with manual lifecycle', async () => { | ||
| await NATIVE.initNativeSdk({ | ||
| dsn: 'https://example@sentry.io/123', | ||
| enableNative: true, | ||
| autoInitializeNativeSdk: true, | ||
| devServerUrl: undefined, | ||
| defaultSidecarUrl: undefined, | ||
| mobileReplayOptions: undefined, | ||
| androidProfilingOptions: { | ||
| profileSessionSampleRate: 1.0, | ||
| lifecycle: 'manual', | ||
| startOnAppStart: false, | ||
| }, | ||
| }); | ||
|
|
||
| expect(RNSentry.initNativeSdk).toHaveBeenCalledWith( | ||
| expect.objectContaining({ | ||
| _experiments: expect.objectContaining({ | ||
| androidProfilingOptions: { | ||
| profileSessionSampleRate: 1.0, | ||
| lifecycle: 'manual', | ||
| startOnAppStart: false, | ||
| }, | ||
| }), | ||
| }), | ||
| ); | ||
| }); | ||
|
|
||
| it('does not pass androidProfilingOptions when undefined', async () => { | ||
| await NATIVE.initNativeSdk({ | ||
| dsn: 'https://example@sentry.io/123', | ||
| enableNative: true, | ||
| autoInitializeNativeSdk: true, | ||
| devServerUrl: undefined, | ||
| defaultSidecarUrl: undefined, | ||
| mobileReplayOptions: undefined, | ||
| androidProfilingOptions: undefined, | ||
| }); | ||
|
|
||
| const callArgs = (RNSentry.initNativeSdk as jest.Mock).mock.calls[0][0]; | ||
| expect(callArgs._experiments?.androidProfilingOptions).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('handles partial androidProfilingOptions', async () => { | ||
| await NATIVE.initNativeSdk({ | ||
| dsn: 'https://example@sentry.io/123', | ||
| enableNative: true, | ||
| autoInitializeNativeSdk: true, | ||
| devServerUrl: undefined, | ||
| defaultSidecarUrl: undefined, | ||
| mobileReplayOptions: undefined, | ||
| androidProfilingOptions: { | ||
| profileSessionSampleRate: 0.3, | ||
| // lifecycle and startOnAppStart not provided | ||
| }, | ||
| }); | ||
|
|
||
| expect(RNSentry.initNativeSdk).toHaveBeenCalledWith( | ||
| expect.objectContaining({ | ||
| _experiments: expect.objectContaining({ | ||
| androidProfilingOptions: { | ||
| profileSessionSampleRate: 0.3, | ||
| }, | ||
| }), | ||
| }), | ||
| ); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.