Skip to content

Conversation

@alwx
Copy link
Contributor

@alwx alwx commented Dec 17, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fixes #5469

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@alwx alwx marked this pull request as ready for review December 17, 2025 17:57
@alwx alwx self-assigned this Dec 17, 2025
@antonis
Copy link
Contributor

antonis commented Dec 18, 2025

@sentry review

@antonis antonis added the ready-to-merge Triggers the full CI test suite label Dec 18, 2025
Comment on lines +11 to +12
### Fixes
- Fix for missing `replay_id` from metrics ([#5483](https://github.com/getsentry/sentry-react-native/pull/5483))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Missing line

Suggested change
### Fixes
- Fix for missing `replay_id` from metrics ([#5483](https://github.com/getsentry/sentry-react-native/pull/5483))
### Fixes
- Fix for missing `replay_id` from metrics ([#5483](https://github.com/getsentry/sentry-react-native/pull/5483))

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 419.81 ms 443.57 ms 23.76 ms
Size 43.75 MiB 48.08 MiB 4.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a3f3291+dirty 414.59 ms 422.76 ms 8.16 ms
2104bb9+dirty 410.71 ms 461.52 ms 50.81 ms
2adbd1e+dirty 433.98 ms 427.96 ms -6.02 ms
70250df+dirty 410.37 ms 416.44 ms 6.07 ms
b7aa1aa+dirty 324.73 ms 327.76 ms 3.03 ms
652f785+dirty 401.02 ms 420.60 ms 19.58 ms
01d24f6+dirty 362.50 ms 362.23 ms -0.27 ms
36841a6+dirty 502.96 ms 547.14 ms 44.18 ms
9a81842+dirty 412.23 ms 416.56 ms 4.33 ms
5526494 440.84 ms 448.36 ms 7.52 ms

App size

Revision Plain With Sentry Diff
a3f3291+dirty 43.75 MiB 48.07 MiB 4.32 MiB
2104bb9+dirty 17.75 MiB 19.74 MiB 1.99 MiB
2adbd1e+dirty 17.75 MiB 19.70 MiB 1.96 MiB
70250df+dirty 43.75 MiB 48.08 MiB 4.33 MiB
b7aa1aa+dirty 17.75 MiB 19.75 MiB 2.00 MiB
652f785+dirty 43.75 MiB 47.99 MiB 4.24 MiB
01d24f6+dirty 17.75 MiB 19.74 MiB 2.00 MiB
36841a6+dirty 43.75 MiB 48.07 MiB 4.32 MiB
9a81842+dirty 43.75 MiB 48.08 MiB 4.33 MiB
5526494 17.75 MiB 19.68 MiB 1.93 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 364.67 ms 392.65 ms 27.99 ms
Size 43.94 MiB 48.91 MiB 4.97 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a3f3291+dirty 399.06 ms 432.43 ms 33.36 ms
5526494+dirty 380.79 ms 432.70 ms 51.91 ms
70250df+dirty 418.08 ms 480.84 ms 62.76 ms
c7f264b+dirty 356.98 ms 407.46 ms 50.48 ms
b7aa1aa+dirty 281.02 ms 317.53 ms 36.51 ms
652f785+dirty 367.80 ms 390.71 ms 22.91 ms
36841a6+dirty 404.22 ms 450.06 ms 45.84 ms
9a81842+dirty 508.08 ms 566.65 ms 58.56 ms
ff5a06a+dirty 438.29 ms 476.00 ms 37.71 ms
b80b14f+dirty 320.33 ms 376.06 ms 55.73 ms

App size

Revision Plain With Sentry Diff
a3f3291+dirty 43.94 MiB 48.90 MiB 4.96 MiB
5526494+dirty 7.15 MiB 8.41 MiB 1.26 MiB
70250df+dirty 43.94 MiB 48.91 MiB 4.97 MiB
c7f264b+dirty 7.15 MiB 8.41 MiB 1.26 MiB
b7aa1aa+dirty 7.15 MiB 8.46 MiB 1.31 MiB
652f785+dirty 43.94 MiB 48.82 MiB 4.88 MiB
36841a6+dirty 43.94 MiB 48.90 MiB 4.96 MiB
9a81842+dirty 43.94 MiB 48.91 MiB 4.97 MiB
ff5a06a+dirty 43.94 MiB 48.87 MiB 4.93 MiB
b80b14f+dirty 43.94 MiB 48.87 MiB 4.93 MiB

@github-actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.45 ms 1217.14 ms -4.31 ms
Size 3.44 MiB 4.59 MiB 1.15 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9bf5446+dirty 1218.60 ms 1210.45 ms -8.15 ms
d916aa3+dirty 1211.02 ms 1221.33 ms 10.31 ms
77061ed+dirty 1210.77 ms 1218.45 ms 7.68 ms
8ece263+dirty 1206.90 ms 1211.45 ms 4.55 ms
73f2455+dirty 1219.85 ms 1218.29 ms -1.56 ms
652f785+dirty 1216.42 ms 1212.21 ms -4.21 ms
07808fb+dirty 1240.76 ms 1251.00 ms 10.24 ms
55b77fc+dirty 1213.08 ms 1218.19 ms 5.11 ms
136effd+dirty 1214.53 ms 1223.67 ms 9.13 ms
7e9c42c+dirty 1204.10 ms 1211.29 ms 7.19 ms

App size

Revision Plain With Sentry Diff
9bf5446+dirty 3.41 MiB 4.59 MiB 1.18 MiB
d916aa3+dirty 3.19 MiB 4.38 MiB 1.19 MiB
77061ed+dirty 3.19 MiB 4.54 MiB 1.36 MiB
8ece263+dirty 3.19 MiB 4.48 MiB 1.29 MiB
73f2455+dirty 3.41 MiB 4.58 MiB 1.17 MiB
652f785+dirty 3.41 MiB 4.57 MiB 1.16 MiB
07808fb+dirty 3.19 MiB 4.56 MiB 1.37 MiB
55b77fc+dirty 3.41 MiB 4.58 MiB 1.17 MiB
136effd+dirty 3.41 MiB 4.57 MiB 1.16 MiB
7e9c42c+dirty 3.41 MiB 4.58 MiB 1.17 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing replay_id from metrics

3 participants