fix(metro): Add next parameter to metroMiddleware to satisfy HandleFunction type #5477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 60bcfad | 381.13 ms | 376.16 ms | -4.97 ms |
| 4646c88 | 420.87 ms | 424.69 ms | 3.82 ms |
| afc8fd1 | 436.18 ms | 435.92 ms | -0.26 ms |
| b5d7446+dirty | 432.76 ms | 427.44 ms | -5.32 ms |
| ea445a4+dirty | 488.62 ms | 527.35 ms | 38.74 ms |
| b241372+dirty | 462.88 ms | 448.42 ms | -14.46 ms |
| ef387f0 | 456.31 ms | 450.67 ms | -5.63 ms |
| b435bf2 | 429.24 ms | 445.24 ms | 16.00 ms |
| a5f26a3 | 438.94 ms | 438.39 ms | -0.55 ms |
| ef17f08+dirty | 426.12 ms | 444.52 ms | 18.40 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 60bcfad | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 4646c88 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| afc8fd1 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| b5d7446+dirty | 17.75 MiB | 19.69 MiB | 1.94 MiB |
| ea445a4+dirty | 43.75 MiB | 48.05 MiB | 4.30 MiB |
| b241372+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| ef387f0 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| b435bf2 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| a5f26a3 | 17.75 MiB | 19.68 MiB | 1.93 MiB |
| ef17f08+dirty | 43.75 MiB | 48.05 MiB | 4.29 MiB |
Previous results on branch: antonis/fix-metroMiddleware
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| df87911+dirty | 403.38 ms | 423.16 ms | 19.78 ms |
| 1be7ae7+dirty | 459.00 ms | 492.00 ms | 33.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| df87911+dirty | 43.75 MiB | 48.07 MiB | 4.32 MiB |
| 1be7ae7+dirty | 43.75 MiB | 48.07 MiB | 4.32 MiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b435bf2+dirty | 374.43 ms | 423.63 ms | 49.20 ms |
| 4646c88+dirty | 399.92 ms | 401.76 ms | 1.84 ms |
| afc8fd1+dirty | 334.53 ms | 405.50 ms | 70.97 ms |
| a5f26a3+dirty | 384.51 ms | 419.94 ms | 35.43 ms |
| b5d7446+dirty | 329.83 ms | 411.14 ms | 81.31 ms |
| ef387f0+dirty | 352.73 ms | 401.00 ms | 48.27 ms |
| 60bcfad+dirty | 336.98 ms | 385.37 ms | 48.39 ms |
| ea445a4+dirty | 405.98 ms | 437.08 ms | 31.10 ms |
| b241372+dirty | 387.19 ms | 419.89 ms | 32.70 ms |
| ef17f08+dirty | 365.84 ms | 403.65 ms | 37.81 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b435bf2+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 4646c88+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| afc8fd1+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| a5f26a3+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| b5d7446+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| ef387f0+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 60bcfad+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| ea445a4+dirty | 43.94 MiB | 48.88 MiB | 4.94 MiB |
| b241372+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| ef17f08+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
Previous results on branch: antonis/fix-metroMiddleware
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| df87911+dirty | 301.23 ms | 323.52 ms | 22.29 ms |
| 1be7ae7+dirty | 420.41 ms | 466.59 ms | 46.18 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| df87911+dirty | 43.94 MiB | 48.90 MiB | 4.96 MiB |
| 1be7ae7+dirty | 43.94 MiB | 48.90 MiB | 4.96 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 60bcfad+dirty | 1219.06 ms | 1218.96 ms | -0.10 ms |
| b5d7446+dirty | 1233.71 ms | 1243.25 ms | 9.54 ms |
| a5f26a3+dirty | 1210.89 ms | 1208.32 ms | -2.57 ms |
| b241372+dirty | 1207.65 ms | 1220.89 ms | 13.24 ms |
| 4646c88+dirty | 1234.20 ms | 1237.58 ms | 3.38 ms |
| afc8fd1+dirty | 1239.69 ms | 1242.44 ms | 2.74 ms |
| ea445a4+dirty | 1206.35 ms | 1211.62 ms | 5.28 ms |
| b435bf2+dirty | 1221.09 ms | 1234.59 ms | 13.50 ms |
| ef387f0+dirty | 1232.45 ms | 1233.88 ms | 1.43 ms |
| f5f5f87+dirty | 1250.61 ms | 1255.90 ms | 5.29 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 60bcfad+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| b5d7446+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| a5f26a3+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
| b241372+dirty | 3.19 MiB | 4.56 MiB | 1.38 MiB |
| 4646c88+dirty | 3.19 MiB | 4.34 MiB | 1.16 MiB |
| afc8fd1+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| ea445a4+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| b435bf2+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| ef387f0+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| f5f5f87+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
Previous results on branch: antonis/fix-metroMiddleware
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1be7ae7+dirty | 1193.90 ms | 1191.00 ms | -2.90 ms |
| df87911+dirty | 1215.59 ms | 1218.57 ms | 2.98 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1be7ae7+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| df87911+dirty | 3.44 MiB | 4.67 MiB | 1.23 MiB |
bruno-garcia
force-pushed
the
deps/scripts/update-wizard.sh
branch
from
0f1490a to
d1d4b0f
Compare
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 60bcfad+dirty | 1206.08 ms | 1205.23 ms | -0.85 ms |
| b5d7446+dirty | 1238.77 ms | 1244.22 ms | 5.45 ms |
| a5f26a3+dirty | 1226.84 ms | 1241.74 ms | 14.90 ms |
| b241372+dirty | 1237.86 ms | 1243.13 ms | 5.27 ms |
| 4646c88+dirty | 1234.76 ms | 1234.11 ms | -0.65 ms |
| afc8fd1+dirty | 1221.19 ms | 1237.13 ms | 15.94 ms |
| ea445a4+dirty | 1221.04 ms | 1217.88 ms | -3.17 ms |
| b435bf2+dirty | 1240.18 ms | 1243.18 ms | 3.00 ms |
| ef387f0+dirty | 1208.24 ms | 1212.71 ms | 4.47 ms |
| f5f5f87+dirty | 1208.47 ms | 1213.30 ms | 4.83 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 60bcfad+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| b5d7446+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| a5f26a3+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
| b241372+dirty | 2.63 MiB | 4.00 MiB | 1.36 MiB |
| 4646c88+dirty | 2.63 MiB | 3.77 MiB | 1.14 MiB |
| afc8fd1+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| ea445a4+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| b435bf2+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| ef387f0+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| f5f5f87+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
Previous results on branch: antonis/fix-metroMiddleware
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1be7ae7+dirty | 1220.25 ms | 1221.52 ms | 1.27 ms |
| df87911+dirty | 1221.78 ms | 1218.60 ms | -3.17 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1be7ae7+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| df87911+dirty | 3.44 MiB | 4.67 MiB | 1.23 MiB |
antonis
commented
Dec 16, 2025
Contributor
Author
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
the failed Sample Application / Test android production REV2 will be handled with #5478
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
bruno-garcia
force-pushed
the
deps/scripts/update-wizard.sh
branch
from
d1d4b0f to
f694c66
Compare
bruno-garcia
force-pushed
the
deps/scripts/update-wizard.sh
branch
from
f694c66 to
c6fbd90
Compare
bruno-garcia
force-pushed
the
deps/scripts/update-wizard.sh
branch
from
c6fbd90 to
feb77e5
Compare
…ddleware # Conflicts: # yarn.lock
bruno-garcia
force-pushed
the
deps/scripts/update-wizard.sh
branch
from
feb77e5 to
ee3c57f
Compare
…ddleware # Conflicts: # packages/core/package.json # yarn.lock
bruno-garcia
force-pushed
the
deps/scripts/update-wizard.sh
branch
from
ee3c57f to
a0952a7
Compare
…ddleware # Conflicts: # yarn.lock
antonis
merged commit 4e50ace
into
deps/scripts/update-wizard.sh
93 of 94 checks passed
antonis
added a commit
that referenced
this pull request
Dec 18, 2025
* chore: update scripts/update-wizard.sh to v6.10.0 * fix(metro): Add next parameter to metroMiddleware to satisfy HandleFunction type (#5477) * chore: update scripts/update-wizard.sh to v6.10.0 * fix(metro): Add next parameter to metroMiddleware to satisfy HandleFunction type * Fixes lint issue * Update test * chore: update scripts/update-wizard.sh to v6.10.0 * Update all tests * chore: update scripts/update-wizard.sh to v6.10.0 * chore: update scripts/update-wizard.sh to v6.10.0 * chore: update scripts/update-wizard.sh to v6.10.0 * chore: update scripts/update-wizard.sh to v6.10.0 --------- Co-authored-by: GitHub <[email protected]> --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: Antonis Lilis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The @sentry/wizard v6.10.0 update brings in @sentry/node@^10.29.0, which transitively requires @types/[email protected] via @opentelemetry/instrumentation-connect. This causes TypeScript to strictly check all overloads of the HandleFunction union type that Middleware is based on.
This PR adds the next parameter to stackFramesContextMiddleware and update createSentryMetroMiddleware to properly pass it, satisfying the NextHandleFunction signature (3 args) which is part of the HandleFunction union.
💡 Motivation and Context
Failed builds (example)
💚 How did you test it?
CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog