improvement(testing): migrating from the deprecated react-test-renderer
#5084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c08359e | 421.87 ms | 445.37 ms | 23.50 ms |
| 98f632c | 424.25 ms | 435.48 ms | 11.23 ms |
| 785ffb1 | 471.92 ms | 460.96 ms | -10.96 ms |
| d916aa3 | 425.37 ms | 427.02 ms | 1.65 ms |
| 3e0a5f9 | 401.72 ms | 394.98 ms | -6.74 ms |
| eb07ba3 | 470.04 ms | 473.35 ms | 3.31 ms |
| e2fa43d | 451.68 ms | 462.42 ms | 10.74 ms |
| 7be1f99 | 454.83 ms | 461.36 ms | 6.53 ms |
| 21c9e75 | 450.39 ms | 452.92 ms | 2.53 ms |
| 64cd15c | 439.02 ms | 427.63 ms | -11.39 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c08359e | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 98f632c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 785ffb1 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| d916aa3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 3e0a5f9 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| eb07ba3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| e2fa43d | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 7be1f99 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 21c9e75 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 64cd15c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e2fa43d+dirty | 326.56 ms | 372.88 ms | 46.32 ms |
| eb07ba3+dirty | 419.49 ms | 482.12 ms | 62.63 ms |
| bc9680d+dirty | 346.77 ms | 463.48 ms | 116.71 ms |
| a0b15d6+dirty | 414.33 ms | 448.85 ms | 34.52 ms |
| c08359e+dirty | 406.04 ms | 428.87 ms | 22.83 ms |
| 785ffb1+dirty | 380.65 ms | 451.83 ms | 71.18 ms |
| 64cd15c+dirty | 488.79 ms | 483.54 ms | -5.24 ms |
| 21c9e75+dirty | 356.73 ms | 381.06 ms | 24.33 ms |
| 3e0a5f9+dirty | 379.92 ms | 450.96 ms | 71.04 ms |
| 98f632c+dirty | 323.98 ms | 375.39 ms | 51.41 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e2fa43d+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| eb07ba3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| bc9680d+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| a0b15d6+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| c08359e+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 785ffb1+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 64cd15c+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 21c9e75+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 3e0a5f9+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 98f632c+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 21c9e75+dirty | 1237.78 ms | 1247.66 ms | 9.88 ms |
| 534ba8c+dirty | 1230.22 ms | 1231.18 ms | 0.96 ms |
| c08359e+dirty | 1235.25 ms | 1233.96 ms | -1.29 ms |
| 3e0a5f9+dirty | 1226.94 ms | 1230.02 ms | 3.08 ms |
| bc9680d+dirty | 1221.41 ms | 1241.47 ms | 20.06 ms |
| eb07ba3+dirty | 1222.46 ms | 1220.37 ms | -2.08 ms |
| a0b15d6+dirty | 1220.18 ms | 1223.18 ms | 3.00 ms |
| e2fa43d+dirty | 1216.04 ms | 1232.65 ms | 16.61 ms |
| 785ffb1+dirty | 1237.63 ms | 1240.50 ms | 2.87 ms |
| d916aa3+dirty | 1221.02 ms | 1228.98 ms | 7.96 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 21c9e75+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 534ba8c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| c08359e+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 3e0a5f9+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| bc9680d+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| eb07ba3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| a0b15d6+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| e2fa43d+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 785ffb1+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| d916aa3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 21c9e75+dirty | 1206.20 ms | 1223.54 ms | 17.35 ms |
| 534ba8c+dirty | 1225.00 ms | 1237.43 ms | 12.43 ms |
| c08359e+dirty | 1200.59 ms | 1211.81 ms | 11.22 ms |
| 3e0a5f9+dirty | 1233.65 ms | 1239.10 ms | 5.45 ms |
| bc9680d+dirty | 1228.57 ms | 1233.64 ms | 5.07 ms |
| eb07ba3+dirty | 1214.49 ms | 1221.59 ms | 7.10 ms |
| a0b15d6+dirty | 1213.79 ms | 1210.45 ms | -3.34 ms |
| e2fa43d+dirty | 1224.43 ms | 1235.40 ms | 10.98 ms |
| 785ffb1+dirty | 1213.71 ms | 1213.37 ms | -0.35 ms |
| d916aa3+dirty | 1211.02 ms | 1221.33 ms | 10.31 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 21c9e75+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 534ba8c+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| c08359e+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 3e0a5f9+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| bc9680d+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| eb07ba3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| a0b15d6+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| e2fa43d+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 785ffb1+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| d916aa3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
alwx
force-pushed
the
alwx/improvement/testing-library
branch
from
55e12f0 to
fe3592e
Compare
alwx
force-pushed
the
alwx/improvement/testing-library
branch
from
fe3592e to
e54eb3c
Compare
alwx
changed the title
react-test-rendererreact-test-renderer
Collaborator
|
Thank you for the PR! overall the tests looks good, but tests are not running sadly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Migrates from the deprecated
react-test-rendererto@testing-library/react-nativewhich is the currently recommended library for UI testing.Fixes #4811
💡 Motivation and Context
It unblocks #4942
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog