Skip to content

fix(feedback): show dev note when trying to retrieve image in ExpoGo #4900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025
Merged

fix(feedback): show dev note when trying to retrieve image in ExpoGo #4900

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fd1951
fix(feedback): show dev note when trying to retrieve image in ExpoGo
antonis Jun 6, 2025
bb5ac12
Fix alignment
antonis Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions packages/core/src/js/feedback/FeedbackWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
View
} from 'react-native';

import { isWeb, notWeb } from '../utils/environment';
import { isExpoGo, isWeb, notWeb } from '../utils/environment';
import type { Screenshot } from '../wrapper';
import { getDataFromUri, NATIVE } from '../wrapper';
import { sentryLogo } from './branding';
Expand Down Expand Up @@ -181,9 +181,11 @@ export class FeedbackWidget extends React.Component<FeedbackWidgetProps, Feedbac
if (data != null) {
this.setState({ filename, attachment: data, attachmentUri: imageUri });
} else {
this._showImageRetrievalDevelopmentNote();
logger.error('Failed to read image data from uri:', imageUri);
}
}).catch((error) => {
this._showImageRetrievalDevelopmentNote();
logger.error('Failed to read image data from uri:', imageUri, 'error: ', error);
});
}
Expand All @@ -196,10 +198,11 @@ export class FeedbackWidget extends React.Component<FeedbackWidgetProps, Feedbac
if (data != null) {
this.setState({ filename: 'feedback_screenshot', attachment: data, attachmentUri: uri });
} else {
this._showImageRetrievalDevelopmentNote();
logger.error('Failed to read image data from uri:', uri);
}
})
.catch((error) => {
}).catch((error) => {
this._showImageRetrievalDevelopmentNote();
logger.error('Failed to read image data from uri:', uri, 'error: ', error);
});
});
Expand Down Expand Up @@ -402,4 +405,13 @@ export class FeedbackWidget extends React.Component<FeedbackWidgetProps, Feedbac
private _hasScreenshot = (): boolean => {
return this.state.filename !== undefined && this.state.attachment !== undefined && this.state.attachmentUri !== undefined;
}

private _showImageRetrievalDevelopmentNote = (): void => {
if (isExpoGo()) {
feedbackAlertDialog(
'Development note',
'The feedback widget cannot retrieve image data in Expo Go. Please build your app to test this functionality.',
);
}
}
}
Loading