fix(ios): setUser to null works with null introduced in RN 0.77.1 #4567

krystofwoldrich · 2025-02-19T12:36:52Z

📢 Type of change

Bugfix

📜 Description

With RN 0.77.1 nullable values in obj-c can be either [NSNull null] or nil which breaks our existing checks. I have not checked the whole RNSentry.mm. But only tested and fixed setUser(null) which crashed the user's app.

💡 Motivation and Context

fixes: Calling Sentry.setUser(null) on React Native v0.77.1 causes a crash on iOS in production / release mode #4553

💚 How did you test it?

sample, integration tests

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

github-actions · 2025-02-19T12:48:27Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	430.26 ms	434.14 ms	3.88 ms
Size	17.75 MiB	20.11 MiB	2.37 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d997097`	470.23 ms	475.46 ms	5.23 ms
`3f05680`	397.91 ms	405.65 ms	7.74 ms
`148f924`	492.65 ms	500.28 ms	7.63 ms
`b6f8ea2`	472.49 ms	469.60 ms	-2.89 ms
`13b68d9`	424.22 ms	419.65 ms	-4.57 ms
`21a0abb`	442.40 ms	422.88 ms	-19.52 ms
`e99226d`	503.41 ms	491.61 ms	-11.80 ms
`690220d`	468.28 ms	480.06 ms	11.78 ms
`8de2810`	430.47 ms	428.72 ms	-1.75 ms
`cdf2f33`	469.46 ms	462.17 ms	-7.29 ms

App size

Revision	Plain	With Sentry	Diff
`d997097`	17.75 MiB	20.11 MiB	2.36 MiB
`3f05680`	17.75 MiB	20.11 MiB	2.37 MiB
`148f924`	17.73 MiB	19.94 MiB	2.21 MiB
`b6f8ea2`	17.75 MiB	20.11 MiB	2.36 MiB
`13b68d9`	17.75 MiB	20.11 MiB	2.37 MiB
`21a0abb`	17.75 MiB	20.11 MiB	2.36 MiB
`e99226d`	17.75 MiB	20.11 MiB	2.36 MiB
`690220d`	17.74 MiB	20.08 MiB	2.35 MiB
`8de2810`	17.74 MiB	20.08 MiB	2.34 MiB
`cdf2f33`	17.74 MiB	20.08 MiB	2.34 MiB

Previous results on branch: kw-set-user-accept-nsnull

Startup times

Revision	Plain	With Sentry	Diff
`a706821`	443.79 ms	463.58 ms	19.79 ms

App size

Revision	Plain	With Sentry	Diff
`a706821`	17.75 MiB	20.11 MiB	2.37 MiB

github-actions · 2025-02-19T12:56:43Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	401.62 ms	398.18 ms	-3.43 ms
Size	7.15 MiB	8.38 MiB	1.23 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	253.73 ms	308.23 ms	54.49 ms
`fc150fe`+dirty	409.55 ms	407.37 ms	-2.18 ms
`457e29f`+dirty	591.49 ms	612.96 ms	21.47 ms
`afe5fcb`+dirty	396.84 ms	449.40 ms	52.56 ms
`80b2ce3`+dirty	271.29 ms	316.47 ms	45.18 ms
`34aba08`+dirty	331.79 ms	376.69 ms	44.91 ms
`e5c9b8b`+dirty	335.40 ms	360.06 ms	24.67 ms
`9a3ca65`+dirty	344.96 ms	358.92 ms	13.96 ms
`ee4aab8`+dirty	494.84 ms	574.57 ms	79.73 ms
`488c9c5`+dirty	448.98 ms	531.62 ms	82.64 ms

App size

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`fc150fe`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`457e29f`+dirty	7.15 MiB	8.10 MiB	981.29 KiB
`afe5fcb`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`80b2ce3`+dirty	7.15 MiB	8.04 MiB	911.02 KiB
`34aba08`+dirty	7.15 MiB	8.07 MiB	946.13 KiB
`e5c9b8b`+dirty	7.15 MiB	8.10 MiB	980.41 KiB
`9a3ca65`+dirty	7.15 MiB	8.09 MiB	962.83 KiB
`ee4aab8`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`488c9c5`+dirty	7.15 MiB	8.38 MiB	1.23 MiB

Previous results on branch: kw-set-user-accept-nsnull

Startup times

Revision	Plain	With Sentry	Diff
`a706821`+dirty	367.27 ms	367.88 ms	0.61 ms

App size

Revision	Plain	With Sentry	Diff
`a706821`+dirty	7.15 MiB	8.38 MiB	1.23 MiB

github-actions · 2025-02-19T13:05:17Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1225.92 ms	1232.54 ms	6.62 ms
Size	2.63 MiB	3.74 MiB	1.11 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`3261206`+dirty	1219.49 ms	1224.10 ms	4.61 ms
`1d86dd6`+dirty	1249.71 ms	1279.16 ms	29.45 ms
`8900e1a`+dirty	1210.27 ms	1218.66 ms	8.39 ms
`4cc5c27`+dirty	1211.45 ms	1214.60 ms	3.16 ms
`6e8584e`+dirty	1274.50 ms	1296.82 ms	22.32 ms
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`6c56eb1`+dirty	1224.29 ms	1232.00 ms	7.71 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms
`a18210a`+dirty	1237.15 ms	1224.85 ms	-12.29 ms
`cdf2f33`+dirty	1227.71 ms	1233.94 ms	6.22 ms

App size

Revision	Plain	With Sentry	Diff
`3261206`+dirty	2.63 MiB	3.69 MiB	1.06 MiB
`1d86dd6`+dirty	2.36 MiB	2.89 MiB	535.43 KiB
`8900e1a`+dirty	2.36 MiB	2.83 MiB	479.25 KiB
`4cc5c27`+dirty	2.36 MiB	3.04 MiB	698.52 KiB
`6e8584e`+dirty	2.36 MiB	2.88 MiB	533.17 KiB
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`6c56eb1`+dirty	2.36 MiB	3.11 MiB	759.87 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB
`a18210a`+dirty	2.63 MiB	3.70 MiB	1.06 MiB
`cdf2f33`+dirty	2.36 MiB	3.10 MiB	751.38 KiB

Previous results on branch: kw-set-user-accept-nsnull

Startup times

Revision	Plain	With Sentry	Diff
`a706821`+dirty	1213.33 ms	1219.44 ms	6.11 ms

App size

Revision	Plain	With Sentry	Diff
`a706821`+dirty	2.63 MiB	3.74 MiB	1.11 MiB

github-actions · 2025-02-19T13:07:12Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1226.43 ms	1229.86 ms	3.43 ms
Size	3.19 MiB	4.31 MiB	1.12 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d16beca`+dirty	1239.00 ms	1233.89 ms	-5.11 ms
`5a22220`+dirty	1246.18 ms	1249.61 ms	3.43 ms
`2534337`+dirty	1220.87 ms	1221.47 ms	0.60 ms
`1d86dd6`+dirty	1289.25 ms	1293.36 ms	4.11 ms
`ddc0552`+dirty	1246.00 ms	1241.98 ms	-4.02 ms
`205982c`+dirty	1228.06 ms	1237.72 ms	9.66 ms
`e4d9fe0`+dirty	1210.45 ms	1204.23 ms	-6.21 ms
`b1e8712`+dirty	1284.11 ms	1297.82 ms	13.71 ms
`afe5fcb`+dirty	1223.53 ms	1223.90 ms	0.37 ms
`21a0abb`+dirty	1224.37 ms	1225.61 ms	1.24 ms

App size

Revision	Plain	With Sentry	Diff
`d16beca`+dirty	2.92 MiB	3.69 MiB	790.48 KiB
`5a22220`+dirty	2.92 MiB	3.48 MiB	575.81 KiB
`2534337`+dirty	2.92 MiB	3.43 MiB	529.76 KiB
`1d86dd6`+dirty	2.92 MiB	3.44 MiB	538.27 KiB
`ddc0552`+dirty	2.92 MiB	3.67 MiB	772.47 KiB
`205982c`+dirty	2.92 MiB	3.67 MiB	772.63 KiB
`e4d9fe0`+dirty	3.19 MiB	4.26 MiB	1.08 MiB
`b1e8712`+dirty	2.92 MiB	3.40 MiB	494.15 KiB
`afe5fcb`+dirty	3.19 MiB	4.26 MiB	1.08 MiB
`21a0abb`+dirty	3.19 MiB	4.26 MiB	1.08 MiB

Previous results on branch: kw-set-user-accept-nsnull

Startup times

Revision	Plain	With Sentry	Diff
`a706821`+dirty	1223.73 ms	1229.94 ms	6.20 ms

App size

Revision	Plain	With Sentry	Diff
`a706821`+dirty	3.19 MiB	4.31 MiB	1.12 MiB

packages/core/ios/RNSentry.mm

packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryUser.mm

krystofwoldrich · 2025-02-20T09:00:14Z

@antonis Thank you, I fixed the comments.

antonis

LGTM 🚀

fix(ios): setUser to null works with null introduced in RN 0.77.1

846f4b2

krystofwoldrich added 2 commits February 19, 2025 16:06

add tests

1c26bdd

fix(changelog): Update PR reference for iOS setUser fix

6029e09

krystofwoldrich marked this pull request as ready for review February 19, 2025 15:09

krystofwoldrich requested review from antonis and lucas-zimerman as code owners February 19, 2025 15:09

krystofwoldrich added 3 commits February 19, 2025 16:18

add more tests

792a25c

fix log

03de9b5

fix c format

0f433a0

antonis reviewed Feb 19, 2025

View reviewed changes

packages/core/ios/RNSentry.mm Outdated Show resolved Hide resolved

antonis reviewed Feb 19, 2025

View reviewed changes

packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryUser.mm Show resolved Hide resolved

krystofwoldrich added 2 commits February 20, 2025 09:57

fix test name

854d256

fix syntax

926421f

antonis approved these changes Feb 20, 2025

View reviewed changes

krystofwoldrich merged commit 4bc69cf into main Feb 20, 2025
70 checks passed

krystofwoldrich deleted the kw-set-user-accept-nsnull branch February 20, 2025 09:51

Uh oh!

fix(ios): setUser to null works with null introduced in RN 0.77.1 #4567

fix(ios): setUser to null works with null introduced in RN 0.77.1 #4567

Conversation

krystofwoldrich commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

Uh oh!

github-actions bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-set-user-accept-nsnull

Startup times

App size

Uh oh!

github-actions bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-set-user-accept-nsnull

Startup times

App size

Uh oh!

github-actions bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-set-user-accept-nsnull

Startup times

App size

Uh oh!

github-actions bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-set-user-accept-nsnull

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

krystofwoldrich commented Feb 20, 2025

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

krystofwoldrich commented Feb 19, 2025 •

edited

Loading

github-actions bot commented Feb 19, 2025 •

edited

Loading

github-actions bot commented Feb 19, 2025 •

edited

Loading

github-actions bot commented Feb 19, 2025 •

edited

Loading

github-actions bot commented Feb 19, 2025 •

edited

Loading