feat(experimental): Initialize Android SDK from json configuration

CHANGELOG.md

@@ -16,6 +16,7 @@
 
 - Rename `navigation.processing` span to more expressive `Navigation dispatch to screen A mounted/navigation cancelled` ([#4423](https://github.com/getsentry/sentry-react-native/pull/4423))
 - Add RN SDK package to `sdk.packages` for Cocoa ([#4381](https://github.com/getsentry/sentry-react-native/pull/4381))
+- Add experimental initialization using `sentry.options.json` and `RNSentrySDK.startWithOptions` method for Android ([#4451](https://github.com/getsentry/sentry-react-native/pull/4451))
 
 ### Dependencies
 
@@ -26,6 +27,10 @@
   - [changelog](https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md#8480)
   - [diff](https://github.com/getsentry/sentry-javascript/compare/8.47.0...8.48.0)
 
+### Internal
+
+- Extract Android native initialization to standalone structures ([#4445](https://github.com/getsentry/sentry-react-native/pull/4445))
+
 ## 6.5.0
 
 ### Features

packages/core/RNSentryAndroidTester/app/src/androidTest/java/io/sentry/rnsentryandroidtester/RNSentryMapConverterTest.kt

@@ -4,10 +4,14 @@ import android.content.Context
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import androidx.test.platform.app.InstrumentationRegistry
 import com.facebook.react.bridge.Arguments
+import com.facebook.react.bridge.JavaOnlyMap
 import com.facebook.soloader.SoLoader
 import io.sentry.react.RNSentryMapConverter
+import org.json.JSONObject
 import org.junit.Assert.assertEquals
+import org.junit.Assert.assertNotNull
 import org.junit.Assert.assertNull
+import org.junit.Assert.assertTrue
 import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
@@ -359,4 +363,40 @@ class MapConverterTest {
 
         assertEquals(actual, expectedMap1)
     }
+
+    @Test
+    fun testJsonObjectToReadableMap() {
+        val json =
+            JSONObject().apply {
+                put("stringKey", "stringValue")
+                put("booleanKey", true)
+                put("intKey", 123)
+            }
+
+        val result = RNSentryMapConverter.jsonObjectToReadableMap(json)
+
+        assertNotNull(result)
+        assertTrue(result is JavaOnlyMap)
+        assertEquals("stringValue", result.getString("stringKey"))
+        assertEquals(true, result.getBoolean("booleanKey"))
+        assertEquals(123, result.getInt("intKey"))
+    }
+
+    @Test
+    fun testMapToReadableMap() {
+        val map =
+            mapOf(
+                "stringKey" to "stringValue",
+                "booleanKey" to true,
+                "intKey" to 123,
+            )
+
+        val result = RNSentryMapConverter.mapToReadableMap(map)
+
+        assertNotNull(result)
+        assertTrue(result is JavaOnlyMap)
+        assertEquals("stringValue", result.getString("stringKey"))
+        assertEquals(true, result.getBoolean("booleanKey"))
+        assertEquals(123, result.getInt("intKey"))
+    }
 }

packages/core/RNSentryAndroidTester/app/src/test/java/io/sentry/react/RNSentryModuleImplTest.kt

@@ -3,20 +3,13 @@ package io.sentry.react
 import android.content.pm.PackageInfo
 import android.content.pm.PackageManager
 import com.facebook.react.bridge.Arguments
-import com.facebook.react.bridge.JavaOnlyMap
 import com.facebook.react.bridge.Promise
 import com.facebook.react.bridge.ReactApplicationContext
 import com.facebook.react.bridge.WritableMap
-import com.facebook.react.common.JavascriptException
-import io.sentry.Breadcrumb
 import io.sentry.ILogger
 import io.sentry.SentryLevel
-import io.sentry.android.core.SentryAndroidOptions
 import org.junit.After
 import org.junit.Assert.assertEquals
-import org.junit.Assert.assertFalse
-import org.junit.Assert.assertNull
-import org.junit.Assert.assertTrue
 import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
@@ -103,163 +96,4 @@ class RNSentryModuleImplTest {
         val capturedMap = writableMapCaptor.value
         assertEquals(false, capturedMap.getBoolean("has_fetched"))
     }
-
-    @Test
-    fun `when the spotlight option is enabled, the spotlight SentryAndroidOption is set to true and the default url is used`() {
-        val options =
-            JavaOnlyMap.of(
-                "spotlight",
-                true,
-                "defaultSidecarUrl",
-                "http://localhost:8969/teststream",
-            )
-        val actualOptions = SentryAndroidOptions()
-        module.getSentryAndroidOptions(actualOptions, options, logger)
-        assert(actualOptions.isEnableSpotlight)
-        assertEquals("http://localhost:8969/teststream", actualOptions.spotlightConnectionUrl)
-    }
-
-    @Test
-    fun `when the spotlight url is passed, the spotlight is enabled for the given url`() {
-        val options = JavaOnlyMap.of("spotlight", "http://localhost:8969/teststream")
-        val actualOptions = SentryAndroidOptions()
-        module.getSentryAndroidOptions(actualOptions, options, logger)
-        assert(actualOptions.isEnableSpotlight)
-        assertEquals("http://localhost:8969/teststream", actualOptions.spotlightConnectionUrl)
-    }
-
-    @Test
-    fun `when the spotlight option is disabled, the spotlight SentryAndroidOption is set to false`() {
-        val options = JavaOnlyMap.of("spotlight", false)
-        val actualOptions = SentryAndroidOptions()
-        module.getSentryAndroidOptions(actualOptions, options, logger)
-        assertFalse(actualOptions.isEnableSpotlight)
-    }
-
-    @Test
-    fun `the JavascriptException is added to the ignoredExceptionsForType list on initialisation`() {
-        val actualOptions = SentryAndroidOptions()
-        module.getSentryAndroidOptions(actualOptions, JavaOnlyMap.of(), logger)
-        assertTrue(actualOptions.ignoredExceptionsForType.contains(JavascriptException::class.java))
-    }
-
-    @Test
-    fun `beforeBreadcrumb callback filters out Sentry DSN requests breadcrumbs`() {
-        val options = SentryAndroidOptions()
-        val rnOptions =
-            JavaOnlyMap.of(
-                "dsn",
-                "https://[email protected]/1234567",
-                "devServerUrl",
-                "http://localhost:8081",
-            )
-        module.getSentryAndroidOptions(options, rnOptions, logger)
-
-        val breadcrumb =
-            Breadcrumb().apply {
-                type = "http"
-                setData("url", "https://def.ingest.sentry.io/1234567")
-            }
-
-        val result = options.beforeBreadcrumb?.execute(breadcrumb, mock())
-
-        assertNull("Breadcrumb should be filtered out", result)
-    }
-
-    @Test
-    fun `beforeBreadcrumb callback filters out dev server breadcrumbs`() {
-        val mockDevServerUrl = "http://localhost:8081"
-        val options = SentryAndroidOptions()
-        val rnOptions =
-            JavaOnlyMap.of(
-                "dsn",
-                "https://[email protected]/1234567",
-                "devServerUrl",
-                mockDevServerUrl,
-            )
-        module.getSentryAndroidOptions(options, rnOptions, logger)
-
-        val breadcrumb =
-            Breadcrumb().apply {
-                type = "http"
-                setData("url", mockDevServerUrl)
-            }
-
-        val result = options.beforeBreadcrumb?.execute(breadcrumb, mock())
-
-        assertNull("Breadcrumb should be filtered out", result)
-    }
-
-    @Test
-    fun `beforeBreadcrumb callback does not filter out non dev server or dsn breadcrumbs`() {
-        val options = SentryAndroidOptions()
-        val rnOptions =
-            JavaOnlyMap.of(
-                "dsn",
-                "https://[email protected]/1234567",
-                "devServerUrl",
-                "http://localhost:8081",
-            )
-        module.getSentryAndroidOptions(options, rnOptions, logger)
-
-        val breadcrumb =
-            Breadcrumb().apply {
-                type = "http"
-                setData("url", "http://testurl.com/service")
-            }
-
-        val result = options.beforeBreadcrumb?.execute(breadcrumb, mock())
-
-        assertEquals(breadcrumb, result)
-    }
-
-    @Test
-    fun `the breadcrumb is not filtered out when the dev server url and dsn are not passed`() {
-        val options = SentryAndroidOptions()
-        module.getSentryAndroidOptions(options, JavaOnlyMap(), logger)
-
-        val breadcrumb =
-            Breadcrumb().apply {
-                type = "http"
-                setData("url", "http://testurl.com/service")
-            }
-
-        val result = options.beforeBreadcrumb?.execute(breadcrumb, mock())
-
-        assertEquals(breadcrumb, result)
-    }
-
-    @Test
-    fun `the breadcrumb is not filtered out when the dev server url is not passed and the dsn does not match`() {
-        val options = SentryAndroidOptions()
-        val rnOptions = JavaOnlyMap.of("dsn", "https://[email protected]/1234567")
-        module.getSentryAndroidOptions(options, rnOptions, logger)
-
-        val breadcrumb =
-            Breadcrumb().apply {
-                type = "http"
-                setData("url", "http://testurl.com/service")
-            }
-
-        val result = options.beforeBreadcrumb?.execute(breadcrumb, mock())
-
-        assertEquals(breadcrumb, result)
-    }
-
-    @Test
-    fun `the breadcrumb is not filtered out when the dev server url does not match and the dsn is not passed`() {
-        val options = SentryAndroidOptions()
-        val rnOptions = JavaOnlyMap.of("devServerUrl", "http://localhost:8081")
-        module.getSentryAndroidOptions(options, rnOptions, logger)
-
-        val breadcrumb =
-            Breadcrumb().apply {
-                type = "http"
-                setData("url", "http://testurl.com/service")
-            }
-
-        val result = options.beforeBreadcrumb?.execute(breadcrumb, mock())
-
-        assertEquals(breadcrumb, result)
-    }
 }