Skip to content

fix(ci): Fixes p-retry version to 6.2.0 #4280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
krystofwoldrich merged 6 commits into from
Nov 16, 2024
Merged

fix(ci): Fixes p-retry version to 6.2.0 #4280

krystofwoldrich merged 6 commits into from
Nov 16, 2024
+3 −3

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Nov 15, 2024 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fixes p-retry version to 6.2.0 since the latest release including sindresorhus/p-retry#82 triggered the issue.

error node_modules/p-retry/index.js: Unexpected token: operator (?) in file node_modules/p-retry/index.js at 51:37.
 Error: Unexpected token: operator (?) in file node_modules/p-retry/index.js at 51:37
    at minifyCode (/home/runner/work/sentry-react-native/sentry-react-native/dev-packages/e2e-tests/react-native-versions/0.65.3/RnDiffApp/node_modules/metro-transform-worker/src/index.js:99:13)
    at transformJS (/home/runner/work/sentry-react-native/sentry-react-native/dev-packages/e2e-tests/react-native-versions/0.65.3/RnDiffApp/node_modules/metro-transform-worker/src/index.js:317:28)
    at transformJSWithBabel (/home/runner/work/sentry-react-native/sentry-react-native/dev-packages/e2e-tests/react-native-versions/0.65.3/RnDiffApp/node_modules/metro-transform-worker/src/index.js:408:16)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Object.transform (/home/runner/work/sentry-react-native/sentry-react-native/dev-packages/e2e-tests/react-native-versions/0.65.3/RnDiffApp/node_modules/metro-transform-worker/src/index.js:569:12)

💡 Motivation and Context

The following failed CI checks:

💚 How did you test it?

CI

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis changed the title fix(ci) Removes yarn cache from build from corepack enable step fix(ci): Removes yarn cache from build from corepack enable step Nov 15, 2024
@antonis antonis changed the title fix(ci): Removes yarn cache from build from corepack enable step fix(ci): Removes yarn cache from corepack enable step Nov 15, 2024
@antonis antonis closed this Nov 15, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 433.58 ms 467.73 ms 34.15 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
34aba08+dirty 331.79 ms 376.69 ms 44.91 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
3853f43+dirty 278.12 ms 338.72 ms 60.60 ms
baa882f+dirty 449.30 ms 540.40 ms 91.10 ms
8c88ac7+dirty 402.72 ms 434.32 ms 31.60 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
d43a46b+dirty 417.65 ms 472.98 ms 55.33 ms
a5d86e1+dirty 380.86 ms 466.42 ms 85.56 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
9c48b2c+dirty 270.82 ms 321.12 ms 50.30 ms

App size

Revision Plain With Sentry Diff
34aba08+dirty 7.15 MiB 8.07 MiB 946.13 KiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
3853f43+dirty 7.15 MiB 8.08 MiB 959.34 KiB
baa882f+dirty 7.15 MiB 8.34 MiB 1.19 MiB
8c88ac7+dirty 7.15 MiB 8.35 MiB 1.20 MiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
d43a46b+dirty 7.15 MiB 8.34 MiB 1.19 MiB
a5d86e1+dirty 7.15 MiB 8.35 MiB 1.20 MiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
9c48b2c+dirty 7.15 MiB 8.07 MiB 947.16 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.82 ms 1226.70 ms -1.12 ms
Size 2.92 MiB 3.66 MiB 756.65 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
62a750b+dirty 1228.12 ms 1230.53 ms 2.41 ms
a989877+dirty 1222.90 ms 1219.89 ms -3.00 ms
484813b+dirty 1225.07 ms 1221.00 ms -4.07 ms
700cbf4+dirty 1233.96 ms 1228.27 ms -5.69 ms
e73d82f+dirty 1231.20 ms 1228.81 ms -2.40 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms
dadc233+dirty 1266.52 ms 1282.55 ms 16.03 ms
d7401ac+dirty 1288.10 ms 1289.54 ms 1.44 ms
b1e8712+dirty 1284.11 ms 1297.82 ms 13.71 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms

App size

Revision Plain With Sentry Diff
62a750b+dirty 2.92 MiB 3.48 MiB 575.59 KiB
a989877+dirty 2.92 MiB 3.66 MiB 757.66 KiB
484813b+dirty 2.92 MiB 3.64 MiB 740.56 KiB
700cbf4+dirty 2.92 MiB 3.64 MiB 740.57 KiB
e73d82f+dirty 2.92 MiB 3.64 MiB 740.56 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB
dadc233+dirty 2.92 MiB 3.40 MiB 492.53 KiB
d7401ac+dirty 2.92 MiB 3.40 MiB 488.06 KiB
b1e8712+dirty 2.92 MiB 3.40 MiB 494.15 KiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB

@antonis antonis reopened this Nov 15, 2024
@antonis antonis changed the title fix(ci): Removes yarn cache from corepack enable step DRAFT: fix(ci): TypeError: URL.canParse is not a function Nov 15, 2024
@antonis antonis changed the title DRAFT: fix(ci): TypeError: URL.canParse is not a function DRAFT: fix(ci): Build RN 0.65.3 legacy Nov 15, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.16 ms 1244.18 ms 13.02 ms
Size 2.36 MiB 3.10 MiB 752.30 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
62a750b+dirty 1216.60 ms 1229.14 ms 12.54 ms
a989877+dirty 1228.56 ms 1227.71 ms -0.85 ms
484813b+dirty 1222.45 ms 1220.79 ms -1.66 ms
700cbf4+dirty 1234.59 ms 1227.71 ms -6.88 ms
e73d82f+dirty 1207.52 ms 1216.73 ms 9.21 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
dadc233+dirty 1223.20 ms 1236.88 ms 13.68 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
b1e8712+dirty 1256.02 ms 1265.14 ms 9.12 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms

App size

Revision Plain With Sentry Diff
62a750b+dirty 2.36 MiB 2.92 MiB 570.00 KiB
a989877+dirty 2.36 MiB 3.10 MiB 752.40 KiB
484813b+dirty 2.36 MiB 3.08 MiB 734.18 KiB
700cbf4+dirty 2.36 MiB 3.08 MiB 734.22 KiB
e73d82f+dirty 2.36 MiB 3.08 MiB 734.23 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
dadc233+dirty 2.36 MiB 2.84 MiB 486.85 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
b1e8712+dirty 2.36 MiB 2.84 MiB 488.84 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB

@antonis antonis closed this Nov 15, 2024
@antonis antonis reopened this Nov 15, 2024
@antonis antonis changed the title DRAFT: fix(ci): Build RN 0.65.3 legacy fix(ci): Fixes p-retry version to 6.2.0 Nov 15, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 473.56 ms 473.35 ms -0.21 ms
Size 17.74 MiB 20.08 MiB 2.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
63ed251 457.74 ms 441.54 ms -16.20 ms
728164b 414.34 ms 449.22 ms 34.88 ms
07e58c9 495.04 ms 489.73 ms -5.31 ms
5a22220 412.38 ms 447.35 ms 34.97 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
baa882f 354.93 ms 356.18 ms 1.25 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
c398f67 449.64 ms 461.38 ms 11.74 ms
e5bc97b 438.96 ms 437.39 ms -1.57 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms

App size

Revision Plain With Sentry Diff
63ed251 17.74 MiB 20.08 MiB 2.34 MiB
728164b 17.73 MiB 19.85 MiB 2.12 MiB
07e58c9 17.74 MiB 20.08 MiB 2.34 MiB
5a22220 17.73 MiB 19.93 MiB 2.20 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
baa882f 17.73 MiB 20.06 MiB 2.33 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
c398f67 17.73 MiB 19.94 MiB 2.21 MiB
e5bc97b 17.74 MiB 20.08 MiB 2.34 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB

@antonis antonis marked this pull request as ready for review November 15, 2024 16:20
krystofwoldrich
krystofwoldrich approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thank you for fixing the so promptly!

@krystofwoldrich krystofwoldrich merged commit bd812a6 into main Nov 16, 2024
67 checks passed
@krystofwoldrich krystofwoldrich deleted the antonis/ci-e2e-build-fix branch November 16, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

1 more reviewer

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonis @krystofwoldrich