Skip to content

fix(tracing) Omit the top level status tag #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2020
Merged

fix(tracing) Omit the top level status tag #644

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddaf57c
fix(tracing) Omit the top level status tag
markstory Mar 9, 2020
ba6033f
fix: Formatting
untitaker Mar 11, 2020
c7067e0
Fix status being dropped on inner spans.
markstory Mar 11, 2020
be93706
Fix black
markstory Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sentry_sdk/tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ def get_trace_context(self):
}

if "status" in self._tags:
rv["status"] = self._tags["status"]
rv["status"] = self._tags.pop("status")

return rv

Expand Down
5 changes: 4 additions & 1 deletion tests/test_tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ def test_basic(sentry_init, capture_events, sample_rate):
sentry_init(traces_sample_rate=sample_rate)
events = capture_events()

with Hub.current.start_span(transaction="hi"):
with Hub.current.start_span(transaction="hi") as span:
span.set_status('ok')
with pytest.raises(ZeroDivisionError):
with Hub.current.start_span(op="foo", description="foodesc"):
1 / 0
Expand All @@ -32,6 +33,8 @@ def test_basic(sentry_init, capture_events, sample_rate):
assert span2["op"] == "bar"
assert span2["description"] == "bardesc"
assert parent_span["transaction"] == "hi"
assert "status" not in event["tags"]
assert event["contexts"]["trace"]["status"] == "ok"
else:
assert not events

Expand Down