Skip to content

Conversation

@sl0thentr0py
Copy link
Member

Description

No longer returns None since the last isolation_scope branch will always have one setup by the constructor.

Issues

@sl0thentr0py sl0thentr0py requested a review from a team as a code owner December 10, 2025 19:39
@linear
Copy link

linear bot commented Dec 10, 2025

@sl0thentr0py sl0thentr0py force-pushed the neel/prop-context-none branch 2 times, most recently from b92b2ae to 62d97ae Compare December 10, 2025 19:42
@sl0thentr0py sl0thentr0py force-pushed the neel/prop-context-none branch from 62d97ae to 516088e Compare December 10, 2025 19:54
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.25%. Comparing base (1ac88a0) to head (516088e).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/scope.py 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           neel/more-prop-context-cleanup    #5217      +/-   ##
==================================================================
+ Coverage                           84.23%   84.25%   +0.01%     
==================================================================
  Files                                 181      181              
  Lines                               18458    18446      -12     
  Branches                             3282     3276       -6     
==================================================================
- Hits                                15549    15542       -7     
+ Misses                               1902     1900       -2     
+ Partials                             1007     1004       -3     
Files with missing lines Coverage Δ
sentry_sdk/scope.py 89.12% <84.61%> (+1.05%) ⬆️

... and 2 files with indirect coverage changes

@sl0thentr0py sl0thentr0py force-pushed the neel/more-prop-context-cleanup branch 2 times, most recently from d5b454a to 598e594 Compare December 11, 2025 13:18
Base automatically changed from neel/more-prop-context-cleanup to master December 11, 2025 13:26
@sl0thentr0py sl0thentr0py force-pushed the neel/prop-context-none branch from 516088e to 52a69b7 Compare December 11, 2025 13:31
@sl0thentr0py sl0thentr0py enabled auto-merge (squash) December 11, 2025 13:32
@sl0thentr0py sl0thentr0py merged commit a1dab84 into master Dec 11, 2025
169 of 175 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/prop-context-none branch December 11, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up PropagationContext None checks

3 participants