Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to jinja2 for generating CI yamls #2534

Merged
merged 15 commits into from
Nov 28, 2023

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Nov 27, 2023

The current approach was becoming hard to maintain. This should make it easier to integrate new frameworks.

@sentrivana sentrivana marked this pull request as ready for review November 27, 2023 13:56
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the outputted files look kind of the same as the old ones, this should work! great work!

@antonpirker
Copy link
Member

The AWS Lambda functions tests now receive two events (one "message": "hi" and one error) the first one should not be there. Not sure why this is happening.

@sentrivana
Copy link
Contributor Author

Fixed AWS Lambda now.

@sentrivana sentrivana merged commit c025ffe into master Nov 28, 2023
468 checks passed
@sentrivana sentrivana deleted the ivana/use-jinja-for-rendering-workflow-yamls branch November 28, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants