-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added top level api to get current span and transaction #1954
Merged
antonpirker
merged 4 commits into
master
from
antonpirker/top-level-get-current-span-transaction
Mar 15, 2023
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
import mock | ||
|
||
from sentry_sdk import ( | ||
configure_scope, | ||
get_current_span_or_transaction, | ||
get_current_span, | ||
get_current_transaction, | ||
start_transaction, | ||
) | ||
|
||
|
||
def test_get_current_span(): | ||
fake_hub = mock.MagicMock() | ||
fake_hub.scope = mock.MagicMock() | ||
|
||
fake_hub.scope.span = mock.MagicMock() | ||
assert get_current_span(fake_hub) == fake_hub.scope.span | ||
|
||
fake_hub.scope.span = None | ||
assert get_current_span(fake_hub) is None | ||
|
||
|
||
def test_get_current_span_default_hub(sentry_init): | ||
sentry_init() | ||
|
||
assert get_current_span() is None | ||
|
||
with configure_scope() as scope: | ||
fake_span = mock.MagicMock() | ||
scope.span = fake_span | ||
|
||
assert get_current_span() == fake_span | ||
|
||
|
||
def test_get_current_transaction(): | ||
fake_hub = mock.MagicMock() | ||
fake_hub.scope = mock.MagicMock() | ||
|
||
fake_hub.scope.transaction = mock.MagicMock() | ||
assert get_current_transaction(fake_hub) == fake_hub.scope.transaction | ||
|
||
fake_hub.scope.transaction = None | ||
assert get_current_transaction(fake_hub) is None | ||
|
||
|
||
def test_get_current_transaction_default_hub(sentry_init): | ||
sentry_init() | ||
|
||
assert get_current_transaction() is None | ||
|
||
with start_transaction() as new_transaction: | ||
assert get_current_transaction() == new_transaction | ||
|
||
|
||
def test_get_current_span_or_transaction(): | ||
fake_hub = mock.MagicMock() | ||
fake_hub.scope = mock.MagicMock() | ||
|
||
fake_hub.scope.span = mock.MagicMock() | ||
fake_hub.scope.transaction = None | ||
assert get_current_span_or_transaction(fake_hub) == fake_hub.scope.span | ||
|
||
fake_hub.scope.span = None | ||
fake_hub.scope.transaction = mock.MagicMock() | ||
assert get_current_span_or_transaction(fake_hub) == fake_hub.scope.transaction | ||
|
||
fake_hub.scope.span = None | ||
fake_hub.scope.transaction = None | ||
assert get_current_span_or_transaction(fake_hub) is None | ||
|
||
|
||
def test_get_current_span_or_transaction_default_hub(sentry_init): | ||
sentry_init() | ||
|
||
assert get_current_span_or_transaction() is None | ||
|
||
with start_transaction() as new_transaction: | ||
assert get_current_span_or_transaction() == new_transaction | ||
|
||
with configure_scope() as scope: | ||
fake_span = mock.MagicMock() | ||
scope.span = fake_span | ||
|
||
assert get_current_span_or_transaction() == fake_span |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you also have to add these to
__init__.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.