Fix regression on default sending behavior of the HttpTransport transport #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiq
approved these changes
Oct 17, 2019
This was referenced Oct 17, 2019
Jean85
approved these changes
Oct 17, 2019
|
Perfect! That is exactly how I understood that it should be. Thanks a bunch for creating the PR and for helping me out understanding current and desired state! |
helhum
approved these changes
Oct 17, 2019
|
I'm not sure we actually want to consider returning |
helhum
reviewed
Oct 17, 2019
HazAT
approved these changes
Oct 17, 2019
…about when the events are sent
ste93cry
deleted the
fix/revert-sending-behavior-change-http-transport
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #904 by fixing one regression introduced in #885. In particular, I accidentally changed the default behavior of the
HttpTransporttransport by sending events immediatly instead of waiting the shutdown of the application. This is a deprecated behavior, but the default must not change at least until3.0as it may have a huge impact on performances