Skip to content

ref(tracing): Update name of attached transaction in set_transaction [NATIVE-444] #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2022
Merged

ref(tracing): Update name of attached transaction in set_transaction [NATIVE-444] #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d321152
ref(tracing): Update name of attached transaction in set_transaction
loewenheim Jan 12, 2022
b3dfa8d
Remove sentry_remove_transaction
loewenheim Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions include/sentry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1192,11 +1192,6 @@ SENTRY_API void sentry_remove_fingerprint(void);
*/
SENTRY_API void sentry_set_transaction(const char *transaction);

/**
* Removes the transaction.
*/
SENTRY_API void sentry_remove_transaction(void);
Copy link
Contributor

@flub flub Jan 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is intentional?

Copy link
Contributor Author

@loewenheim loewenheim Jan 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, after talking with @relaxolotl on Slack. The method doesn't exist in other SDKs and doesn't do anything other than call sentry_set_transaction(NULL) anyway.


/**
* Sets the event level.
*/
Expand Down
12 changes: 6 additions & 6 deletions src/sentry_core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,13 +712,13 @@ sentry_set_transaction(const char *transaction)
SENTRY_WITH_SCOPE_MUT (scope) {
sentry_free(scope->transaction);
scope->transaction = sentry__string_clone(transaction);
}
}

void
sentry_remove_transaction(void)
{
sentry_set_transaction(NULL);
#ifdef SENTRY_PERFORMANCE_MONITORING
if (!sentry_value_is_null(scope->span)) {
sentry_transaction_set_name(scope->span, transaction);
}
#endif
}
}

void
Expand Down
1 change: 0 additions & 1 deletion tests/unit/test_uninit.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ SENTRY_TEST(uninitialized)
sentry_set_fingerprint("foo", "bar", NULL);
sentry_remove_fingerprint();
sentry_set_transaction("foo");
sentry_remove_transaction();
sentry_set_level(SENTRY_LEVEL_DEBUG);
sentry_start_session();
sentry_end_session();
Expand Down