Skip to content

Conversation

@Swatinem
Copy link
Member

@Swatinem Swatinem commented Oct 1, 2020

Not quite sure if we should do this in the backend, or rather patch the unwinder itself…

fixes #384

@Swatinem Swatinem requested a review from a team October 1, 2020 14:46
@codecov-commenter
Copy link

Codecov Report

Merging #387 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
+ Coverage   87.49%   87.53%   +0.03%     
==========================================
  Files          49       49              
  Lines        4142     4147       +5     
==========================================
+ Hits         3624     3630       +6     
+ Misses        518      517       -1     

@Mixaill
Copy link
Contributor

Mixaill commented Oct 1, 2020

When we use direct unwind, do we need to skip 1 (or more) frame to hide sentry?

@GenuineAster
Copy link
Contributor

image
5 frames including the signal handler.

@flub
Copy link
Contributor

flub commented Oct 2, 2020

I'm not sure if we should hide frames. If this should be done at all perhaps just collapsing them by default in the UI is probably better (which I think might already happen)?

@Swatinem
Copy link
Member Author

Swatinem commented Oct 2, 2020

We don’t flag frames as in_app on native (yet). But yes, I would also say we should not truncate anything on the SDK side. Maybe we will set in_app in the future at some point.

@Swatinem Swatinem merged commit b631816 into master Oct 3, 2020
@Swatinem Swatinem deleted the fix/unwind-ucontext branch October 3, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No frames found when unwinding backtrace on Linux after SIGSEGV

7 participants