Optional user_context #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets `breadcrumbs.user_context` state as a boolean.
The current implementation assumes the default Laravel auth implementation. For anyone who uses auth schemes that aren't part of the core, this leaves lots of debris on the command line: `sentry.breadcrumbs error=Auth guard driver [api] is not defined.` This change makes this optional behavior and doesn't alter it in any way.
dcramer
reviewed
Feb 21, 2017
| $client->user_context(array( | ||
| 'id' => $user->getAuthIdentifier(), | ||
| )); | ||
| if($user_config['breadcrumbs.user_context']) { |
There was a problem hiding this comment.
we wouldnt want to call this breadcrumbs, but not sure if 'user_context' is descriptive enough.
maybe user_context.auto = True/False?
There was a problem hiding this comment.
That works for me. If you'd like I can write up a little blurb on this feature.
|
i made three changes:
|
|
when will it be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation assumes the default Laravel auth implementation. For anyone who uses auth schemes that aren't part of the core, this leaves lots of debris on the command line:
sentry.breadcrumbs error=Auth guard driver [api] is not defined.This change makes this optional behavior and doesn't alter it in any way.