Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: user_context default tracking to false #132

Merged
merged 1 commit into from
Apr 30, 2018
Merged

fix: user_context default tracking to false #132

merged 1 commit into from
Apr 30, 2018

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Apr 30, 2018 •
edited
Loading

We decided to disable user tracking by default in all SDKs.
This is only to make sure users of the SDK really have to opt-in to track user information.

@HazAT HazAT requested a review from mitsuhiko April 30, 2018 10:46
@HazAT HazAT self-assigned this Apr 30, 2018
@HazAT HazAT changed the title fix: user_context default tracking to false [WIP] fix: user_context default tracking to false Apr 30, 2018
stayallive
stayallive approved these changes Apr 30, 2018
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, LGTM!

@HazAT HazAT changed the title [WIP] fix: user_context default tracking to false fix: user_context default tracking to false Apr 30, 2018
@HazAT HazAT merged commit e7f9c37 into master Apr 30, 2018
@HazAT HazAT deleted the fix/user_context branch April 30, 2018 11:45
@HazAT
Copy link
Member Author

HazAT commented Apr 30, 2018

I've merged this now.
Knowing that this may be not the only thing we have to do.
We will need to add something to sentry-php too -> opt-in to ip address tracking.
But this still needs a definition because we want to streamline this setting in all SDKs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko

Assignees

@HazAT HazAT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HazAT @stayallive