Update SENTRY_DSN -> SENTRY_LARAVEL_DSN #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@stayallive Isn't this a breaking change? |
|
No. Since right now So as long as you have the dsn set the old way that will apply untill you switch over if you need to. It is currently “broken” bit this change wont do anything for existing installations. |
|
Also this is being release as 0.9 probably and this allows for breakong changes anyhow :) Will be documented in the changelog too. |
stayallive
added a commit
that referenced
this pull request
Apr 23, 2019
* Fallback to SENTRY_DSN if defined in env #136 #105 #130 * Fix broken config syntax Co-authored-by: Daniel Griesser <[email protected]> Co-authored-by: Alex Bouma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the problems from #105.