Skip to content

feat(replay): Consider user input in form field as "user activity" #7355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billyvg merged 4 commits into from
Mar 7, 2023
Merged

feat(replay): Consider user input in form field as "user activity" #7355

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4067668
feat(replay): Consider user input in form field as "user activity"
billyvg Mar 7, 2023
9539765
CR + add unit test
billyvg Mar 7, 2023
416670c
Merge branch 'develop' into feat-replay-user-input-as-activity
billyvg Mar 7, 2023
9a56d7a
Merge branch 'develop' into feat-replay-user-input-as-activity
billyvg Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/replay/src/coreHandlers/addBreadcrumbEvent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export function addBreadcrumbEvent(replay: ReplayContainer, breadcrumb: Breadcru
return;
}

if (breadcrumb.category === 'ui.click') {
if (['ui.click', 'ui.input'].includes(breadcrumb.category || '')) {
Copy link
Copy Markdown
Member

@mydea mydea Mar 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: IMHO we do not need the || '' part, it should still work with includes(undefined) - we can safe some bytes by doing includes(breadcrumb.category as string) (to satisfy TS)?

replay.triggerUserActivity();
} else {
replay.checkAndHandleExpiredSession();
Expand Down