test: Fix flaky droppedError test

packages/integration-tests/playwright.config.ts

@@ -4,8 +4,8 @@ const config: PlaywrightTestConfig = {
   retries: 0,
   // Run tests inside of a single file in parallel
   fullyParallel: true,
-  // Use 5 workers on CI, else use defaults (based on available CPU cores)
-  // Note that 5 is a random number selected to work well with our CI setup
-  workers: process.env.CI ? 5 : undefined,
+  // Use 3 workers on CI, else use defaults (based on available CPU cores)
+  // Note that 3 is a random number selected to work well with our CI setup
+  workers: process.env.CI ? 3 : undefined,
 };
 export default config;

packages/integration-tests/suites/replay/errors/droppedError/test.ts

@@ -17,49 +17,58 @@ import { getReplayEvent, shouldSkipReplayTest, waitForReplayRequest } from '../.
  * TODO: Once we have lifecycle hooks, we should revisit this test and make sure it behaves as expected.
  *       This means that the recording should not be started or stopped if the error that triggered it is not sent.
  */
-sentryTest(
-  '[error-mode] should start recording if an error occurred although the error was dropped',
-  async ({ getLocalTestPath, page }) => {
-    if (shouldSkipReplayTest()) {
-      sentryTest.skip();
-    }
+for (let i = 0; i < 100; i++) {
+  sentryTest(
+    `[error-mode] should start recording if an error occurred although the error was dropped RUN ${i}`,
+    async ({ getLocalTestPath, page }) => {
+      if (shouldSkipReplayTest()) {
+        sentryTest.skip();
+      }
 
-    let callsToSentry = 0;
-    const reqPromise0 = waitForReplayRequest(page, 0);
+      const reqPromise0 = waitForReplayRequest(page, 0);
+      const reqPromise1 = waitForReplayRequest(page, 1);
+      const reqPromise2 = waitForReplayRequest(page, 2);
 
-    await page.route('https://dsn.ingest.sentry.io/**/*', route => {
-      callsToSentry++;
-      return route.fulfill({
-        status: 200,
-        contentType: 'application/json',
-        body: JSON.stringify({ id: 'test-id' }),
+      let callsToSentry = 0;
+
+      await page.route('https://dsn.ingest.sentry.io/**/*', route => {
+        callsToSentry++;
+
+        return route.fulfill({
+          status: 200,
+          contentType: 'application/json',
+          body: JSON.stringify({ id: 'test-id' }),
+        });
       });
-    });
 
-    const url = await getLocalTestPath({ testDir: __dirname });
+      const url = await getLocalTestPath({ testDir: __dirname });
+
+      await page.goto(url);
+      await page.click('#go-background');
+      expect(callsToSentry).toEqual(0);
 
-    await page.goto(url);
-    await page.click('#go-background');
-    expect(callsToSentry).toEqual(0);
+      await page.click('#error');
+      const req0 = await reqPromise0;
 
-    await page.click('#error');
-    const req0 = await reqPromise0;
+      await page.click('#go-background');
+      await reqPromise1;
 
-    await page.click('#go-background');
-    expect(callsToSentry).toEqual(2); // 2 replay events
+      await page.click('#log');
+      await page.click('#go-background');
+      await reqPromise2;
 
-    await page.click('#log');
-    await page.click('#go-background');
+      // Note: The fact that reqPromise1/reqPromise2 are fulfilled prooves that the recording continues
 
-    const event0 = getReplayEvent(req0);
+      const event0 = getReplayEvent(req0);
 
-    expect(event0).toEqual(
-      getExpectedReplayEvent({
-        contexts: { replay: { error_sample_rate: 1, session_sample_rate: 0 } },
-        // This is by design. A dropped error shouldn't be in this list.
-        error_ids: [],
-        replay_type: 'error',
-      }),
-    );
-  },
-);
+      expect(event0).toEqual(
+        getExpectedReplayEvent({
+          contexts: { replay: { error_sample_rate: 1, session_sample_rate: 0 } },
+          // This is by design. A dropped error shouldn't be in this list.
+          error_ids: [],
+          replay_type: 'error',
+        }),
+      );
+    },
+  );
+}

packages/nextjs/playwright.config.ts

@@ -8,9 +8,9 @@ const config: PlaywrightTestConfig = {
   },
   // Run tests inside of a single file in parallel
   fullyParallel: true,
-  // Use 5 workers on CI, else use defaults (based on available CPU cores)
-  // Note that 5 is a random number selected to work well with our CI setup
-  workers: process.env.CI ? 5 : undefined,
+  // Use 3 workers on CI, else use defaults (based on available CPU cores)
+  // Note that 3 is a random number selected to work well with our CI setup
+  workers: process.env.CI ? 3 : undefined,
   webServer: {
     cwd: path.join(__dirname, 'test', 'integration'),
     command: 'yarn start',

packages/remix/playwright.config.ts

@@ -7,9 +7,9 @@ const config: PlaywrightTestConfig = {
   },
   // Run tests inside of a single file in parallel
   fullyParallel: true,
-  // Use 5 workers on CI, else use defaults (based on available CPU cores)
-  // Note that 5 is a random number selected to work well with our CI setup
-  workers: process.env.CI ? 5 : undefined,
+  // Use 3 workers on CI, else use defaults (based on available CPU cores)
+  // Note that 3 is a random number selected to work well with our CI setup
+  workers: process.env.CI ? 3 : undefined,
   webServer: {
     command: '(cd test/integration/ && yarn build && yarn start)',
     port: 3000,