Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix): Make sure the domain is created before running. #6852

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Jan 18, 2023

Resolves: #6821

This problem appears not to be a flaky test, it's a node bug recurring on certain versions, which apparently happens rarely, and our testing environment (high concurrency in a small container maybe) seems to amplify its frequency.

Looks like this can happen when the domain is used right after the creation, which is the case in our Remix implementation. And the proposed workaround seems to resolve it with this PR. (8 CI runs without errors here, only failed case is #6848, will be addressed with another PR).

For reference:
#2089
nodejs/node#30122
nodejs/node#40999

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.82 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.47 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.5 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.77 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.21 KB (0%)
@sentry/browser - Webpack (minified) 66.17 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.24 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.48 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.74 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.03 KB (+0.02% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.12 KB (-1.16% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.83 KB (-1.57% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.37 KB (-0.86% 🔽)

@onurtemizkan onurtemizkan marked this pull request as ready for review January 19, 2023 12:42
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me - and another reason why we should get rid of domains soon. Thanks for taking a look Onur!

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) January 19, 2023 12:58
@AbhiPrasad AbhiPrasad merged commit 71432dd into master Jan 19, 2023
@AbhiPrasad AbhiPrasad deleted the onur/remix-domain-enter-bug branch January 19, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky CI]: Remix Node 14 Integration Tests Domain "Cannot read property 'enter' of undefined"
2 participants