fix(remix): Make sure the domain is created before running. #6852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #6821
This problem appears not to be a flaky test, it's a node bug recurring on certain versions, which apparently happens rarely, and our testing environment (high concurrency in a small container maybe) seems to amplify its frequency.
Looks like this can happen when the domain is used right after the creation, which is the case in our Remix implementation. And the proposed workaround seems to resolve it with this PR. (8 CI runs without errors here, only failed case is #6848, will be addressed with another PR).
For reference:
#2089
nodejs/node#30122
nodejs/node#40999