Remove remaining deprecated context/fetchContext code #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Good riddance. |
| // context: [] context is stubbed | ||
| }; | ||
|
|
||
| Raven._globalOptions.fetchContext = true; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #542 we removed most of TraceKit's source fetching code (everything except TraceKit's context parsing of old Opera error messages).
This finishes the job by killing the remaining TraceKit code, and also removing
_extractContextFromFramefrom src/raven.js.To clarify once again, this only removes client-side context/source fetching. Sentry server will still fetch source/context from 1) your publicly-accessible JavaScript sources, and 2) release artifacts uploaded directly to Sentry.