Don't access document if undefined #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvinegar
force-pushed
the
no-document
branch
from
b20d5ad
to
c9e33d4
Compare
| @@ -5,6 +5,8 @@ | |||
| // since JSON is required to encode the payload | |||
| var _Raven = window.Raven, | |||
| hasJSON = !!(typeof JSON === 'object' && JSON.stringify), | |||
| // Raven can run in contexts where there's no document (react-native) | |||
| hasDocument = typeof document !== 'undefined', | |||
There was a problem hiding this comment.
Why not use isUndefined(document)?
There was a problem hiding this comment.
On second thought – isUndefined is declared halfway through the file, and I like the declaration of hasDocument at the very top in that big var statement.
There was a problem hiding this comment.
But it gets hoisted, yo.
There was a problem hiding this comment.
I know it does, but it seems gross to assume that a function is hoisted on the very first JavaScript statement in a file.
benvinegar
force-pushed
the
no-document
branch
3 times, most recently
from
a59513e
to
769ab0b
Compare
benvinegar
added a commit
that referenced
this pull request
Sep 16, 2015
Don't access document if undefined
1 task
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.