feat(solid): Add support for TanStack Router Solid #17735
Conversation
thedanchez
force-pushed
the
tanstack-router-solid
branch
from
c097831 to
58e80ed
Compare
|
Hi @thedanchez, thanks for also contributing the docs. Will take a look after the corresponding PR. |
|
Hi @andreiborza! Apologies for the delay. I was out of commission with an illness the past few days. Here is the companion docs PR for this feature |
thedanchez
force-pushed
the
tanstack-router-solid
branch
from
58e80ed to
cf38998
Compare
|
Hi @andreiborza, any updates on this PR? |
andreiborza
changed the title
|
Hey @andreiborza , just a friendly nudge on this again. Are we able to get this reviewed? Really trying to integrate Sentry into my enterprise Solid app that uses TanStack Router Solid |
|
Hey @thedanchez just chiming in here – thanks for the contribution! EDIT: @andreiborza will take of landing the rest of this PR, but he's OOO this week! |
|
Hey @thedanchez, I reviewed the PR and it looks good to me. I just need to make some small adjustments. In the solid sdk, we can mark the router as an optional peer dep so we don't really have to vendor these types in probably. I'm traveling at the moment, I might not get to it until next week. Thanks for the contribution! |
andreiborza
force-pushed
the
tanstack-router-solid
branch
from
08a2b82 to
f8c2df6
Compare
andreiborza
requested review from
Lms24,
RulaKhaled and
chargome
and removed request for
a team
andreiborza
force-pushed
the
tanstack-router-solid
branch
from
f8c2df6 to
137ce94
Compare
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #17735 --------- Co-authored-by: andreiborza <[email protected]>
# Summary This PR adds support for TanStack Router Solid. It follows the same outline as the existing implementation of TanStack Router React for Sentry as both TanStack Router flavors are built on the same agnostic foundation. --------- Co-authored-by: Andrei Borza <[email protected]>
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #17735 --------- Co-authored-by: andreiborza <[email protected]>
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR This PR is the documentation complement to getsentry/sentry-javascript#17735 which adds support for TanStack Router Solid within Sentry. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [x] Low: I can wait a week but I would love for this to be merged and the `@sentry/solid` package to be updated + published as soon as possible as I am building an enterprise application using Sentry + TanStack Router Solid ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: Andrei <[email protected]>
|
Amazing! Thank you all! @andreiborza @chargome would the |
|
@thedanchez this has been released with 10.20.0. |
3 participants
Summary
This PR adds support for TanStack Router Solid. It follows the same outline as the existing implementation of TanStack Router React for Sentry as both TanStack Router flavors are built on the same agnostic foundation.