fix(v8/svelte): Guard component tracking beforeUpdate call
#15262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms/fix-svelte-5-component-tracking-guard
branch
from
fbee874 to
0a50a53
Compare
3 tasks
Lms24
commented
Feb 3, 2025
Comment on lines
+26
to
+27
| ...DEFAULT_SENTRY_OPTIONS.componentTracking, | ||
| ...(sentryOptions && sentryOptions.componentTracking), |
There was a problem hiding this comment.
this was a bug previously, not sure how we missed this, given we have a lot of tests...
Lms24
requested review from
a team,
lforst,
AbhiPrasad and
s1gr1d
and removed request for
a team and
AbhiPrasad
Lms24
changed the title
beforeUpdate callbeforeUpdate call
Lms24
force-pushed
the
lms/fix-svelte-5-component-tracking-guard
branch
from
4641fac to
f865ebd
Compare
s1gr1d
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a guard the Svelte SDK's component update tracking feature to catch an error thrown by Svelte 5 in Runes mode. In Runes mode, components must not call the old
beforeUpdateorafterUpdatelifecycle hooks. Usually, when users do this in their code, the Svelte compiler would throw a build error. However, since ourwithSentryConfigwrapper adds a preprocessor that sneaks such a function call in, the compiler doesn't notice this (at least not in the webpack loader as reported in ##15259.This PR also cleans up the preprocessor adding logic which was overcomplicated and a leftover from when we added more than one preprocessor to users' svelte configs. In general, I cleaned up some unnecessary stuff and terminology.
I'll open a follow-up PR for v9 where I'll disable update tracking by default (see #15259 (comment))
closes #15259