fix(core): fatal
events should set session as crashed
#15072
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Electron SDK, we have to manually set sessions as crashed when native crashes are encountered:
https://github.com/getsentry/sentry-electron/blob/dabd6daf0c19c2a6f224d1e721eb5d58c3cf61ac/src/main/integrations/sentry-minidump/index.ts#L175
This has the downside that if you return
null
inbeforeSend
, the event still impacts the release health crash rate.I found that this was required because
_updateSessionFromEvent
in@sentry/core
does not consider the Electron native events as a crash or an error because there are no exceptions in the event.This PR ensures that any event with a
fatal
level is considered a crash.