Skip to content

Typing question for the "requestHandler" function in "sentry-javascript/packages/node/src/handlers.ts" #2424

@pgmystery

Description

@pgmystery

Package + Version

  • @sentry/browser
  • @sentry/node
  • raven-js
  • raven-node (raven for node)
  • other:

Version:

5.12.3

Description

The function "parseRequest" from "sentry-javascript/packages/node/src/handlers.ts" supports for options -> request a boolean or string array. But the "requestHandler" function in the same file, only supports boolean for options -> request. Is there a reason why the "requestHandler" doesn't include the string array in the typings ?

export function parseRequest( event: Event, req: { [key: string]: any; }, options?: { request?: boolean | string[]; },

export function requestHandler(options?: { request?: boolean; }): (req: http.IncomingMessage, res: http.ServerResponse, next: (error?: any) => void) => void {

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions