Skip to content

Commit

Permalink
feat(vue): Drop vue-router peerDep (#4764)
Browse files Browse the repository at this point in the history
We previously added vue-router as a peer dependency because we rely on
it's existence for Vue Performance Monitoring's router instrumentation.
We never import directly from this though, we always rely on the user
passing it in afterwards. As such, we don't really need to define
a peerDep for the vue-router package.

We use a similar pattern for the react-router stuff, and it has worked
out super well.
  • Loading branch information
AbhiPrasad authored Mar 23, 2022
1 parent 69c6874 commit 2209dab
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions packages/vue/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
"tslib": "^1.9.3"
},
"peerDependencies": {
"vue": "2.x || 3.x",
"vue-router": "3.x || 4.x"
"vue": "2.x || 3.x"
},
"devDependencies": {
"jsdom": "^16.2.2"
Expand Down

0 comments on commit 2209dab

Please sign in to comment.